bigtop-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Boudnik <>
Subject Re: Code review tools
Date Wed, 28 Nov 2012 20:11:53 GMT
To chime in with Bruno earlier - having a review board doesn't mean that
patches shouldn't posted on JIRAs as we do right now. Otherwise, this would be
an enforcement of the tooling, which I oppose big time.


On Wed, Nov 28, 2012 at 12:02PM, Jonathan Hsieh wrote:
>    I'm not that active here, but if you want bigtop setup on
> all it just takes filing a apache INFRA jira and a
>    little patience to get it done.  Once it is up, you post patches there.
>     I'm from HBase-land and I generally ask for review board only on patches
>    that are larger than a 1-2 screen-fulls.
>    Jon.
>    On Tue, Nov 27, 2012 at 5:08 PM, Mark Grover <>
>    wrote:
>      Hi all,
>      When reviewing Bigtop patches, I often find myself downloading the
>      patch, applying it to my local repo and using a diff tool on my computer
>      to review the patch (and have some context around it). I know for a fact
>      that some of the other Apache projects are very good about asking people
>      to post reviews on reviewboard (or something similar) when uploading a
>      new patch. That makes the process of reviewing the diff and commenting
>      on patches much easier.
>      Would it make sense for us to start leveraging something
>      like for this? 
>      Thoughts?
>      Mark
>    --
>    // Jonathan Hsieh (shay)
>    // Software Engineer, Cloudera
>    //

View raw message