From commits-return-4041-archive-asf-public=cust-asf.ponee.io@bigtop.apache.org Tue Jun 12 03:14:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2BA29180647 for ; Tue, 12 Jun 2018 03:14:16 +0200 (CEST) Received: (qmail 8500 invoked by uid 500); 12 Jun 2018 01:14:16 -0000 Mailing-List: contact commits-help@bigtop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: bigtop-dev@bigtop.apache.org Delivered-To: mailing list commits@bigtop.apache.org Received: (qmail 8491 invoked by uid 99); 12 Jun 2018 01:14:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jun 2018 01:14:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1456DE09F3; Tue, 12 Jun 2018 01:14:16 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: junhe@apache.org To: commits@bigtop.apache.org Message-Id: <5c54810e0b284ba89ec3e7d96ab79f52@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: bigtop git commit: BIGTOP-3042: HDFS TestHDFSQuota doesn't match Hadoop's definition Date: Tue, 12 Jun 2018 01:14:16 +0000 (UTC) Repository: bigtop Updated Branches: refs/heads/master d16afea0b -> f993cdb6d BIGTOP-3042: HDFS TestHDFSQuota doesn't match Hadoop's definition The smoke test case of HDFS, TestHDFSQuota:testInputValues, asserts fail on setSpaceQuota to 0, while this doesn't match Hadoop's definition for SpaceQuota. This produces false failure, and should be removed from testcases. This closes #366 Change-Id: I5e18a15e9b45a1057174717a37008b3c92bab0e9 Signed-off-by: Jun He Project: http://git-wip-us.apache.org/repos/asf/bigtop/repo Commit: http://git-wip-us.apache.org/repos/asf/bigtop/commit/f993cdb6 Tree: http://git-wip-us.apache.org/repos/asf/bigtop/tree/f993cdb6 Diff: http://git-wip-us.apache.org/repos/asf/bigtop/diff/f993cdb6 Branch: refs/heads/master Commit: f993cdb6db1135e3b1a1c7f001a95c256ac0155f Parents: d16afea Author: Jun He Authored: Thu Jun 7 09:17:01 2018 +0800 Committer: Jun He Committed: Tue Jun 12 01:13:08 2018 +0000 ---------------------------------------------------------------------- .../org/apache/bigtop/itest/hadoop/hdfs/TestHDFSQuota.groovy | 2 -- 1 file changed, 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/bigtop/blob/f993cdb6/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestHDFSQuota.groovy ---------------------------------------------------------------------- diff --git a/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestHDFSQuota.groovy b/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestHDFSQuota.groovy index a80f27b..3364328 100644 --- a/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestHDFSQuota.groovy +++ b/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestHDFSQuota.groovy @@ -136,8 +136,6 @@ public class TestHDFSQuota { assertTrue("setSpaceQuota should not have worked", shHDFS.getRet() != 0); shHDFS.exec("hadoop dfsadmin -setQuota 0 $testQuotaFolder1"); assertTrue("setQuota should not have worked", shHDFS.getRet() != 0); - shHDFS.exec("hadoop dfsadmin -setSpaceQuota 0 $testQuotaFolder1"); - assertTrue("setSpaceQuota should not have worked", shHDFS.getRet() != 0); shHDFS.exec("hadoop dfsadmin -setQuota $LARGE $testQuotaFolder1"); assertTrue("setQuota failed", shHDFS.getRet() == 0); shHDFS.exec("hadoop dfsadmin -setSpaceQuota $LARGE $testQuotaFolder1");