Mailing-List: contact dev-help@beehive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Beehive Developers" <dev@beehive.apache.org>
Received-SPF: pass (asf.osuosl.org: domain of carlin.rogers@gmail.com
 designates 64.233.162.207 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=RCbvwIm2xhdCx34oRbmhG2W5Ib70Mj0WUVTntjhKzNWx+nYUeYhoE80WhJqhsNjdFNIBpWrRbyf35UhPaaCnoJco2n0klOe4xh/4KxZiXiCEFAkVa1DwtyLiuO9UgrRV3f8i6zJ564m1fCQJAflzI+EZ6o/QatkBxR+q/rU3mHU=
Message-ID: <ba6911de0606302106y2e5b6b32t6d7b26e2d0efe6f0@mail.gmail.com>
Date: Fri, 30 Jun 2006 22:06:12 -0600
From: "Carlin Rogers" <carlin.rogers@gmail.com>
To: "Beehive Developers" <dev@beehive.apache.org>
Subject: Re: Netui compiler bvts
In-Reply-To: <2fd2f0570606301834u445457f3s8fbd10903e776d81@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_10939_6579036.1151726772977"
References: <2fd2f0570606301834u445457f3s8fbd10903e776d81@mail.gmail.com>

------=_Part_10939_6579036.1151726772977
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Thanks for looking at this Andrew! Appreciate your contributions.

My vote would be to always diff the generated page flow validation files.

Carlin

On 6/30/06, Andrew McCulloch <amccullo@gmail.com> wrote:
>
>     I am working on a patch for BEEHIVE-1118 which involves the order that
> form validations are performed.  The bug looks like it comes down to the
> way
> the pageflow-validation-*.xml file is generated.  In addition to the three
> testRecorder drts that need to change with this fix I am writing a new
> compiler bvt test case.
>
>     Currently the compiler bvts only diff the struts-config*.xml files
> against expected results.  I have a patch to the JUnit class that performs
> the file comparisons to make diffing the generated validation files
> mandatory (like he struts config files are), however, I wanted to know if
> this is the best choice.  It would also be easy to modify the test to only
> diff the file if an expected result file is present.  This would only miss
> the case where a validation file is generated unnecessarily.  It would
> however avoid changing the other compiler bvts that may use Jpf validation
> annotations already.  Alternatively I could add some sort of flag or
> properties file to trigger the diffing of the validation files only when
> desired.  This choice would be extensible and be easily adjusted to
> handled
> any other generated files.
>
>     If this seems like a worthwhile change to the netui compiler bvts I
> would like to hear how others think it would be best to handle this.  My
> initial thought is that it would be best to always diff the pageflow
> validation files.
>
> --Andrew
>
>

------=_Part_10939_6579036.1151726772977--