beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew McCulloch" <amccu...@gmail.com>
Subject Re: [jira] Commented: (BEEHIVE-206) control property constraint:AnnotationMemberTypes.Date accept one format
Date Tue, 27 Jun 2006 19:13:48 GMT
Hi Eddie,

I did look into writing a JUnit test for this, but, since with or without
this patch the particular error case is still a compile error I did not see
a way to write a test that fit into the current test framework.  Is there a
current way to write JUint tests to verify compiler errors/error messages
(in this case due to malformed annotation values)?  In this case the bug was
re-opened because the error was incorrect, I think the original issue did
have a existing test case.

On 6/27/06, Chad Schoettger <chad.schoettger@gmail.com> wrote:
>
> I believe back when I made the original fix I added a tch case, I'll
> verify that.  Andrew's patch just changed the error message displayed
> when the test case fails.
>
> - Chad
>
> On 6/27/06, Eddie O'Neil <ekoneil@gmail.com> wrote:
> > Chad / Andrew --
> >
> >   Thanks for the patch and fix -- do we have a test of this in
> > Controls somewhere?  If not, could we add a JUnit one?
> >
> > Eddie
> >
> >
> > On 6/27/06, Chad Schoettger <chad.schoettger@gmail.com> wrote:
> > > Hi Andrew,
> > >
> > > Welcome to the Beehive community.   Thanks for the patch, I've applied
> > > and committed it to svn.
> > >
> > > One tip for generating patch files:
> > > When possible do your diff to generate the patch from your
> > > <beehive/trunk> directory as this makes it a bit easier to apply.
> > >
> > > Thanks again for providing the patch --  hopefully your first of many.
> > >
> > >   - Chad
> > >
> > > On 6/26/06, Andrew McCulloch (JIRA) <dev@beehive.apache.org> wrote:
> > > >     [
> http://issues.apache.org/jira/browse/BEEHIVE-206?page=comments#action_12417889]
> > > >
> > > > Andrew McCulloch commented on BEEHIVE-206:
> > > > ------------------------------------------
> > > >
> > > > When I use the test attached by James against the attached patch the
> new error message is...
> > > >
> > > >       [apt]
> /dev/svn/beehive/trunk/controls/test/src/units/org/apache/beehive/controls/test/java/property/MemberTypeTest.java:69:
> A value assigned to a control property does not satisfy its constraints.
> Cause: The value, 2007/01/31, assigned to maxValue date constraint property
> is not in the specified format of: EEE, MMM d, ''yy
> > > >       [apt]     private PersonControlBean thisPerson;
> > > >       [apt]                                   ^
> > > >       [apt] 1 error
> > > >
> > > >
> > > > I believe this is the expected error for the attached version of
> this testcase.
> > > >
> > > >
> > > > > control property constraint:AnnotationMemberTypes.Date accept one
> format
> > > > >
> ------------------------------------------------------------------------
> > > > >
> > > > >          Key: BEEHIVE-206
> > > > >          URL: http://issues.apache.org/jira/browse/BEEHIVE-206
> > > > >      Project: Beehive
> > > > >         Type: Bug
> > > >
> > > > >   Components: Controls
> > > > >     Versions: V1Beta
> > > > >     Reporter: James Song
> > > > >     Assignee: Chad Schoettger
> > > > >     Priority: Minor
> > > > >  Attachments: MemberTypeTest.java, MemberTypeTest.java,
> PersonControl.java, PersonControl.java, diff-BEEHIVE-206.txt
> > > > >
> > > > > Currently, AnnotationMemberTypes.Date only accept YYYY/MM/DD.
> > > > > There will be cases when user would like to specify the HH:MM, or
> other input format, such as long date format.
> > > >
> > > > --
> > > > This message is automatically generated by JIRA.
> > > > -
> > > > If you think it was sent incorrectly contact one of the
> administrators:
> > > >    http://issues.apache.org/jira/secure/Administrators.jspa
> > > > -
> > > > For more information on JIRA, see:
> > > >    http://www.atlassian.com/software/jira
> > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message