beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eddie O'Neil (JIRA)" <...@beehive.apache.org>
Subject [jira] Created: (BEEHIVE-1083) netui leaks PageFlowContext object attached to ThreadLocal
Date Fri, 24 Mar 2006 17:06:41 GMT
netui leaks PageFlowContext object attached to ThreadLocal
----------------------------------------------------------

         Key: BEEHIVE-1083
         URL: http://issues.apache.org/jira/browse/BEEHIVE-1083
     Project: Beehive
        Type: Bug
  Components: NetUI  
    Versions: 1.0.1    
    Reporter: Eddie O'Neil
 Assigned to: Eddie O'Neil 
    Priority: Blocker
     Fix For: v.next


In the PageFlowRequestProcessor and PageFlowPageFilter, a NetUI ThreadLocal of type PageFlowContext
is attached to the thread, but since it's never unattached, it's leaked into the thread pool.
 In Tomcat where threads are generally servicing web related requests (NetUI ones where there's
only one webapp deployed), this doesn't surface as an issue.  

But, in a broader container, this reference holds onto aServletRequest, ServletResponse, and
ServletContext object which can cause problems when a server handles broader requests over
a longer period of time.

Seems that there are two options:
1) removing the PageFlowContext from the thread local entirely
2) removing the PageFlowContext from the thread local at the end of the servlet / filter

I'm leaning toward (1) because the thread local is only used inside of the simple tags that
were added in October but haven't really shipped yet.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message