beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Tam (JIRA)" <...@beehive.apache.org>
Subject [jira] Updated: (BEEHIVE-1051) Control Interceptor SPI missing throwable for event dispatching
Date Thu, 26 Jan 2006 20:47:11 GMT
     [ http://issues.apache.org/jira/browse/BEEHIVE-1051?page=all ]

Kenneth Tam updated BEEHIVE-1051:
---------------------------------

    Attachment: ControlBean.vm.diff
                Interceptor.java.diff

Good catch.  Here's a proposed fix that makes postEvent symmetric with postInvoke (adding
the return value and throwable to the postEvent signature).  Does this solve your issue, Xibin?


> Control Interceptor SPI missing throwable for event dispatching
> ---------------------------------------------------------------
>
>          Key: BEEHIVE-1051
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1051
>      Project: Beehive
>         Type: Bug
>   Components: Controls
>     Versions: 1.0.1
>  Environment: ALL
>     Reporter: Xibin Zeng
>     Assignee: Kenneth Tam
>  Attachments: ControlBean.vm.diff, Interceptor.java.diff
>
> There are 4 methods on the org.apache.beehive.controls.spi.svc.Interceptorinterface.

> For a control operation, preInvoke/postInvoke are called before and after the operation,
respectively. The postInvoke callback contains the exception that the operation threw. For
preEvent/postEvent, which is called before and after control event dispatching, however, there
is no exception information passed to the postEvent callback. This looks inconsistent to me.
> Imagine that you need to enforce J2EE transaction behaviors using these interceptors
(i.e. rollback a transaction in case of a system exception), you will need to know what exception
has been generated as the result of invoking the operation or event callback. You could do
this for your control operations, but not event callbacks, since the exception caught during
event callback isn't passsed to the interceptor.
> In my humble opinion, I think we should make preInvoke/postinvoke and preEvent/postEvent
API's symmetric.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message