beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlin Rogers (JIRA)" <...@beehive.apache.org>
Subject [jira] Commented: (BEEHIVE-1020) Move the persisting of ScopedRequest attributes out of the beehive NetUI layer
Date Tue, 13 Dec 2005 17:35:46 GMT
    [ http://issues.apache.org/jira/browse/BEEHIVE-1020?page=comments#action_12360320 ] 

Carlin Rogers commented on BEEHIVE-1020:
----------------------------------------

With svn revision 356545 I added another minor change to protect against a possible NPE. In
the now deprecated ScopedRequestImpl.restoreAttributes() method we should only call the new
setAttributeMap() if the saved attributes are not null. Made this change to avoid a NPE in
code still using the deprecated methods.

> Move the persisting of ScopedRequest attributes out of the beehive NetUI layer
> ------------------------------------------------------------------------------
>
>          Key: BEEHIVE-1020
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1020
>      Project: Beehive
>         Type: Improvement
>   Components: NetUI
>     Versions: V1
>     Reporter: Carlin Rogers
>     Assignee: Alejandro Ramirez
>      Fix For: 1.1
>  Attachments: j1020-patch.txt
>
> I plan to modify the ScopedRequest interface in NetUI to move the persisting of ScopedRequest
attributes out of the beehive NetUI layer.
> I would deprecate the persistAttributes()/restoreAttributes() from ScopedRequest interface
and replace them with something like getAttributeMap()/setAttributeMap(). The new getAttributeMap()
method would just return the attribute map and setAttributeMap() sets/merges the attributes
like we do in restoreAttributes(). Then outside the beehive layer an implementation would
control the actual placement of persisted attributes into the session or whatever other persistence
location is desired.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message