Return-Path: Delivered-To: apmail-beehive-dev-archive@www.apache.org Received: (qmail 67935 invoked from network); 19 Sep 2005 23:48:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Sep 2005 23:48:02 -0000 Received: (qmail 11441 invoked by uid 500); 19 Sep 2005 23:48:02 -0000 Delivered-To: apmail-beehive-dev-archive@beehive.apache.org Received: (qmail 11424 invoked by uid 500); 19 Sep 2005 23:48:02 -0000 Mailing-List: contact dev-help@beehive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Beehive Developers" Delivered-To: mailing list dev@beehive.apache.org Received: (qmail 11413 invoked by uid 99); 19 Sep 2005 23:48:01 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Sep 2005 16:48:01 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received: from [64.233.162.199] (HELO zproxy.gmail.com) (64.233.162.199) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Sep 2005 16:48:10 -0700 Received: by zproxy.gmail.com with SMTP id n1so737492nzf for ; Mon, 19 Sep 2005 16:47:00 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:x-accept-language:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; b=uawxakSqO7ebtzBmgKIWO6CfKEbBUrU9R0i4l4X79knmbbkrFHdCfzFV33gR94VRBLTBv3xBVYasXTyoypClG+NZytdpZwcgfpe2gLh6t2vVlKQRttdh6nTwqo5g1XKip2OW+br/iDRsl2ZUi6qYQOA6QoyV/4GfWRMsR9CysN8= Received: by 10.36.46.15 with SMTP id t15mr2793542nzt; Mon, 19 Sep 2005 16:47:00 -0700 (PDT) Received: from ?10.36.33.155? ( [63.96.174.221]) by mx.gmail.com with ESMTP id 18sm6616644nzo.2005.09.19.16.46.59; Mon, 19 Sep 2005 16:47:00 -0700 (PDT) Message-ID: <432F4DF2.5000902@gmail.com> Date: Mon, 19 Sep 2005 17:46:58 -0600 From: Rich Feit User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Beehive Developers Subject: Re: PATCH [jira] Resolved: (BEEHIVE-881) -Aweb.source.roots option to Page Flow annotation processors is unnecessary References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I see -- the patch doesn't add -sourcepath because it was already there in the file. :) Alex Ramirez wrote: >Actually, -sourcepath is already there. Look at: > > >-----Original Message----- >From: Rich Feit [mailto:richfeit@gmail.com] >Sent: Monday, September 19, 2005 5:39 PM >To: Beehive Developers >Subject: Re: PATCH [jira] Resolved: (BEEHIVE-881) -Aweb.source.roots >option to Page Flow annotation processors is unnecessary > >Hey Alex, > >It looks like you deleted -Aweb.source.roots, but didn't add >-sourcepath. I'd expect that to blow up. It didn't cause any error >messages? > >Rich > >Alex Ramirez wrote: > > > >>Rich, >>For some reason I'm unable to attach the patch to the jira issue so >> >> >here > > >>it is. >> >>Alex >> >>-----Original Message----- >>From: Rich Feit (JIRA) [mailto:dev@beehive.apache.org] >>Sent: Friday, September 16, 2005 3:36 PM >>To: dev@beehive.apache.org >>Subject: [jira] Resolved: (BEEHIVE-881) -Aweb.source.roots option to >>Page Flow annotation processors is unnecessary >> >> [ http://issues.apache.org/jira/browse/BEEHIVE-881?page=all ] >> >>Rich Feit resolved BEEHIVE-881: >>------------------------------- >> >> Resolution: Fixed >> Assign To: Alejandro Ramirez (was: Rich Feit) >> >>This was fixed with revision 279881. If you're running the annotation >>processor manually (through an apt command line), you can now just pass >>'-sourcepath ' instead of '-Aweb.source.roots='. >> >> >> >> >> >>>-Aweb.source.roots option to Page Flow annotation processors is >>> >>> >>> >>> >>unnecessary >> >> >>----------------------------------------------------------------------- >> >> >- > > >>--- >> >> >> >> >>> Key: BEEHIVE-881 >>> URL: http://issues.apache.org/jira/browse/BEEHIVE-881 >>> Project: Beehive >>> Type: Bug >>> Components: NetUI >>> Versions: v1m1 >>> Reporter: Rich Feit >>> Assignee: Alejandro Ramirez >>> Fix For: TBD >>> >>> >>> >>> >> >> >> >> >>>Currently, the Page Flow annotation processors discern the apt >>> >>> >>> >>> >>sourcepath by reading the value of -Aweb.source.roots. They can just >> >> >as > > >>well read the value of -sourcepath directly. >> >> >> >>----------------------------------------------------------------------- >> >> >- > > >>Index: >> >> >netui/test/src/compilerTests/org/apache/beehive/netui/test/compiler/RunA >pt.java > > >>=================================================================== >>--- >> >> >netui/test/src/compilerTests/org/apache/beehive/netui/test/compiler/RunA >pt.java (revision 290295) > > >>+++ >> >> >netui/test/src/compilerTests/org/apache/beehive/netui/test/compiler/RunA >pt.java (working copy) > > >>@@ -134,8 +134,6 @@ >> >> aptArgs.add("-Aweb.content.root=" + webappRoot); >> aptArgs.add("-Aweb.output.root=" + webappRoot); >>- aptArgs.add("-Aweb.source.roots=" + webappRoot + >> >> >File.pathSeparatorChar + webappRoot + File.separatorChar > > >>- + TestPropertyMgr.DIRNAME_WEB_INF + >> >> >File.separatorChar + TestPropertyMgr.SRC_DIR_NAME); > > >> // Find all the source files by the specified extentions >> Set srcExtentions = TestPropertyMgr.getSrcExts(); >> >> >> >> > > > >