Return-Path: Delivered-To: apmail-beehive-dev-archive@www.apache.org Received: (qmail 77596 invoked from network); 16 Sep 2005 17:03:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 16 Sep 2005 17:03:05 -0000 Received: (qmail 91979 invoked by uid 500); 16 Sep 2005 17:03:04 -0000 Delivered-To: apmail-beehive-dev-archive@beehive.apache.org Received: (qmail 91958 invoked by uid 500); 16 Sep 2005 17:03:03 -0000 Mailing-List: contact dev-help@beehive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Beehive Developers" Delivered-To: mailing list dev@beehive.apache.org Received: (qmail 91943 invoked by uid 99); 16 Sep 2005 17:03:03 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Sep 2005 10:03:03 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of richfeit@gmail.com designates 64.233.162.204 as permitted sender) Received: from [64.233.162.204] (HELO zproxy.gmail.com) (64.233.162.204) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Sep 2005 10:03:12 -0700 Received: by zproxy.gmail.com with SMTP id l1so91144nzf for ; Fri, 16 Sep 2005 10:02:59 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:x-accept-language:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; b=NkedubLGp4FSy07oqMHSok/J2qjSuzif0iW794NNkdwzOt9QzguX5znoHgNU7V637Sm62Ne5+WEPJT9BpGTIyqPmRUREDNMk9MeulWWJr3vWncSXZvl+Ge84HQGaZrHIuFPbiu+1kFZkjiMp5cIY6eBaewr0IEg0QSeur7hiGYs= Received: by 10.36.74.18 with SMTP id w18mr238384nza; Fri, 16 Sep 2005 10:02:50 -0700 (PDT) Received: from ?172.24.28.216? ( [63.96.166.92]) by mx.gmail.com with ESMTP id 22sm2065477nzn.2005.09.16.10.02.41; Fri, 16 Sep 2005 10:02:42 -0700 (PDT) Message-ID: <432AFAAC.5020707@gmail.com> Date: Fri, 16 Sep 2005 11:02:36 -0600 From: Rich Feit User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Beehive Developers Subject: Re: [PATCH] BEEHIVE-934: Remove XMLBean dependence from the internal processed annotations support References: <432AE284.5000401@gmail.com> <432AE8DB.6000105@bea.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Ah, that makes sense. Thanks for making the other changes, Carlin. Rich Carlin Rogers wrote: >OK, a new patch was attached to this issue in JIRA. > >Rich there was one change I did not make. I didn't replace >AnnotationAttribute class with a Map because the Attribute has a couple of >possible values for value... a String, or 0..N ProcessedAnnotation. I left >the class for clarity and having multiple casts, but we could easily remove >it after this commit without any impact. Let me know what you think Rich. I >really can go either way on this one. > >On 9/16/05, Carlin Rogers wrote: > > >>Will do. Patch coming shortly. >> >>Carlin >> >>On 9/16/05, Eddie O'Neil wrote: >> >> >>>I'm just running BVTs now, so it's not hard to just back the change out >>>and take a new patch. >>> >>>Since there's a file rename in here, want to fix-up the patch and >>>re-attach it to the JIRA issue? >>>Then, I can just re-spin the tests. >>> >>>Eddie >>> >>> >>> >>>Carlin Rogers wrote: >>> >>> >>>>Rich, Thanks for the input. Yes, I originally was using a map but >>>>thought that it might be good to keep the set of beans complete >>>>for clarity. I'll go ahead and make all these changes as suggested >>>>and create another patch. >>>> >>>>Eddie, do you want me to wait until you've done an initial commit? >>>>What works best for you? >>>> >>>>On 9/16/05, Rich Feit < richfeit@gmail.com> wrote: >>>> >>>> >>>>>I agree -- good stuff! Thanks for doing it, Carlin. I have three >>>>> >>>>> >>>small >>> >>> >>>>>comments -- these can be addressed either before or after the checkin >>>>>(all minor). >>>>> >>>>>- AnnotationAttributes and AnnotatedElements could be stored >>>>>directly in maps within their parent beans. That way, there's no >>>>>looping needed when they're being read in AnnotationReader. >>>>>- No need to trim() the values you get. Since the compiler layer is >>>>>doing the generation, there shouldn't be any extra spaces. >>>>>- The class Annotations should probably be called >>>>>ProcessedAnnotations, for clarity. >>>>> >>>>>Thanks, >>>>>Rich >>>>> >>>>>Eddie O'Neil wrote: >>>>> >>>>> >>>>> >>>>>>Carlin-- >>>>>> >>>>>>Thanks; this is great -- it should complete the decoupling of the >>>>>>NetUI webapp runtime from our dependence on the apache-xbean.jarfile. >>>>>>Will get this in tomorrow morning and start on the webapp template >>>>>>next. >>>>>> >>>>>>Eddie >>>>>> >>>>>> >>>>>> >>>>>>On 9/16/05, Carlin Rogers wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>>Eddie, Rich, >>>>>>> >>>>>>>I just attached a patch to >>>>>>>http://issues.apache.org/jira/browse/BEEHIVE-934with changes to >>>>>>>replace the ProcessedAnnotations XMLBean with our own Java >>>>>>>Beans. The processed annotations file is parsed using DOM. >>>>>>> >>>>>>>I've assigned it to Eddie but Rich should also take a look and see >>>>>>> >>>>>>> >>>what >>> >>> >>>>>he >>>>> >>>>> >>>>>>>thinks. Let me know if I need to change anything. >>>>>>> >>>>>>>Carlin >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>> >>> > > >