beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlin Rogers <carlin.rog...@gmail.com>
Subject Re: [PATCH] BEEHIVE-863: support for passing form fields to a popup window
Date Mon, 26 Sep 2005 21:24:36 GMT
I've updated the patch for this such that it merges and resolves conflicts
with changes from
BEEHIVE-542<http://issues.apache.org/jira/browse/BEEHIVE-542>and
BEEHIVE-945 <http://issues.apache.org/jira/browse/BEEHIVE-945>. Please
ignore the original patch and just review the newer one (j863-patch2.txt).

If/when this first patch goes in, please reassign it to me and I can address
additional changes to finish this feature. Thanks.

Carlin

On 9/2/05, Carlin Rogers <carlin.rogers@gmail.com> wrote:
>
> I've got a first cut implementation for the NetUI configurePopup tag
> support for passing form fields to a popup window (see BEEHIVE-863). Here
> are the comments I added to JIRA about the patch and some thoughts about my
> implementation...
>
> "The patch includes changes to the NetUI configurePopup tag, PopupSupport
> class, and the JavaScript in the javaScript.properties to add support for
> passing form fields to a popup window. There is now a new passFormFields
> attribute on the configurePopup tag. If this is set to true, then the
> generated JavaScript will include a function that takes the form name and
> then pulls the name/value pairs from the form fields to include as
> parameters of the query on the url of the popup window request.
>
> This patch is for post V1. Any ideas for how to best modify this patch to
> leverage or refactor existing JavaScript support for url params in the
> netui-datagrid.js would be great. Also, to get and use the real/generated
> form name within the configurePopup tag, I made a local copy of the
> HtmlBaseTag.getNearestForm() method. ConfigurePopup does not subclass from
> HtmlBaseTag and didn't think it should and I didn't see a good way yet to
> avoid the duplication so ideas appreciated here as well.
>
> The patch also includes a test page flow with popups and a testRecorder
> file. The testRecorder file may need updating if the generated JavaScript
> gets tweaked.
>
> Note that this patch builds on top of my patch for BEEHIVE-542 (multiple
> popup scripts generated). So this patch also contains those same changes as
> they are not checked into trunk.
>
> Thanks,
> Carlin
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message