beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlin Rogers <carlin.rog...@gmail.com>
Subject Re: [PATCH] BEEHIVE-934: Remove XMLBean dependence from the internal processed annotations support
Date Fri, 16 Sep 2005 15:52:31 GMT
Will do. Patch coming shortly.

Carlin

On 9/16/05, Eddie O'Neil <ekoneil@bea.com> wrote:
> 
> 
> I'm just running BVTs now, so it's not hard to just back the change out 
> and take a new patch.
> 
> Since there's a file rename in here, want to fix-up the patch and 
> re-attach it to the JIRA issue?
> Then, I can just re-spin the tests.
> 
> Eddie
> 
> 
> 
> Carlin Rogers wrote:
> > Rich, Thanks for the input. Yes, I originally was using a map but
> > thought that it might be good to keep the set of beans complete
> > for clarity. I'll go ahead and make all these changes as suggested
> > and create another patch.
> >
> > Eddie, do you want me to wait until you've done an initial commit?
> > What works best for you?
> >
> > On 9/16/05, Rich Feit <richfeit@gmail.com> wrote:
> >> I agree -- good stuff! Thanks for doing it, Carlin. I have three small
> >> comments -- these can be addressed either before or after the checkin
> >> (all minor).
> >>
> >> - AnnotationAttributes and AnnotatedElements could be stored
> >> directly in maps within their parent beans. That way, there's no
> >> looping needed when they're being read in AnnotationReader.
> >> - No need to trim() the values you get. Since the compiler layer is
> >> doing the generation, there shouldn't be any extra spaces.
> >> - The class Annotations should probably be called
> >> ProcessedAnnotations, for clarity.
> >>
> >> Thanks,
> >> Rich
> >>
> >> Eddie O'Neil wrote:
> >>
> >>> Carlin--
> >>>
> >>> Thanks; this is great -- it should complete the decoupling of the
> >>> NetUI webapp runtime from our dependence on the apache-xbean.jar file.
> >>> Will get this in tomorrow morning and start on the webapp template
> >>> next.
> >>>
> >>> Eddie
> >>>
> >>>
> >>>
> >>> On 9/16/05, Carlin Rogers <carlin.rogers@gmail.com> wrote:
> >>>
> >>>
> >>>> Eddie, Rich,
> >>>>
> >>>> I just attached a patch to
> >>>> http://issues.apache.org/jira/browse/BEEHIVE-934with changes to
> >>>> replace the ProcessedAnnotations XMLBean with our own Java
> >>>> Beans. The processed annotations file is parsed using DOM.
> >>>>
> >>>> I've assigned it to Eddie but Rich should also take a look and see 
> what
> >> he
> >>>> thinks. Let me know if I need to change anything.
> >>>>
> >>>> Carlin
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>>
> >
> 
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message