beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eddie O'Neil" <ekon...@bea.com>
Subject Re: [jira] Assigned: (BEEHIVE-908) missing "onCreate()" and "onDestroy()" methods in pageflow_tutorial Controller.java
Date Wed, 07 Sep 2005 00:47:55 GMT

   I could go either way -- unless we do something with them in that 
tutorial beyond just saying that they exist, I'd say remove them and 
point to the lifecycle doc as the definitive place to refer to onCreate 
/ onDestroy.

   As I recall, there were a bunch of places that the docs had onCreate 
and onDestroy sitting in code samples but not doing anything, so I 
whacked them.  Must've just been over zealous on one.  :)

Eddie



Rich Feit wrote:
> The tutorial does mention onCreate/onDestroy right above the source code 
> for Controller.java, so I think it's weird that it's not there.
> 
>    "The onCreate() method is executed whenever the Controller class is 
> first instantiated. The onDestroy() method is executed when the 
> Controller class is destroyed.
> 
>     After the onCreate() method is run, ..."
> 
> I think that we should either add these methods (without the comments) 
> to the code, or remove the text about them.  They're in the Lifecycle 
> doc now, so I actually think it would be fine to remove them from the 
> tutorial, especially since it's not showing anything but empty 
> implementations.  What do you think?
> 
> Rich
> 
> 
> Eddie O'Neil wrote:
> 
>>
>>   Actually, I think we should talk about this one before fixing it -- 
>> I would prefer to keep the onCreate and onDestroy methods out of the 
>> Page Flow Tutorial.  They're definitely interesting in the context of 
>> a document on a JPF's lifecycle, but IMHO, they're not something to 
>> cover when someone is writing their first Page Flow from scratch.
>>
>>   Rich or Daryl, what do you think?
>>
>> Eddie
>>
>>
>>
>> Steve Hanson (JIRA) wrote:
>>
>>>      [ http://issues.apache.org/jira/browse/BEEHIVE-908?page=all ]
>>>
>>> Steve Hanson reassigned BEEHIVE-908:
>>> ------------------------------------
>>>
>>>     Assign To: Steve Hanson
>>>
>>>> missing "onCreate()" and "onDestroy()" methods in pageflow_tutorial 
>>>> Controller.java
>>>> -----------------------------------------------------------------------------------

>>>>
>>>>
>>>>          Key: BEEHIVE-908
>>>>          URL: http://issues.apache.org/jira/browse/BEEHIVE-908
>>>>      Project: Beehive
>>>>         Type: Bug
>>>>   Components: Documentation
>>>>     Versions: V1
>>>>  Environment: WinXP SP2
>>>>     Reporter: Yongqin Xu
>>>>     Assignee: Steve Hanson
>>>>     Priority: Minor
>>>
>>>
>>>> in step 2, section "Examine the Controller.java and index.jsp 
>>>> Files", the Controller.java from netui-blank is missing:
>>>>    /**
>>>>      * Callback that is invoked when this controller instance is 
>>>> created.
>>>>      */
>>>>     protected void onCreate()
>>>>     {
>>>>     }
>>>>     /**
>>>>      * Callback that is invoked when this controller instance is 
>>>> destroyed.
>>>>      */
>>>>     protected void onDestroy(HttpSession session)
>>>>     {
>>>>     }
>>>
>>>
>>

Mime
View raw message