beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlin Rogers (JIRA)" <beehive-...@incubator.apache.org>
Subject [jira] Commented: (BEEHIVE-880) Remove trailing '?' from URLTemplate.format(true)
Date Mon, 15 Aug 2005 22:42:54 GMT
    [ http://issues.apache.org/jira/browse/BEEHIVE-880?page=comments#action_12318850 ] 

Carlin Rogers commented on BEEHIVE-880:
---------------------------------------

Actually, the current templates in the urlTemplates test web app have markers for 
tests located after the '?' character and before the "{url:queryString}" token. Adding
a testRecorder test in this web app will not exercise this change. However, the
patch that was added does include the junit test to verify.

In addition, one could verify this change by locally modifying an existing
template in the WEB-INF/beehive-url-template-config.xml file of the urlTemplates
web app, then build, deploy, and hit an existing test page. Details follow...

- Change the template named "jpf-action" so that the template value is
"http://{url:domain}:{url:port}/{url:path}?{url:queryString}"
- Build and deploy the urlTemplates test web app.
- Browse the testUrlTemplates/testUrlTemplatesController.jpf test page 
manually and look at the page source.

The first anchor tag in the page should have an 
href="http://localhost:8080/urlTemplates/testUrlTemplates/begin.do"
rather than
href="http://localhost:8080/urlTemplates/testUrlTemplates/begin.do?"


> Remove trailing '?' from URLTemplate.format(true)
> -------------------------------------------------
>
>          Key: BEEHIVE-880
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-880
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: v1m1
>     Reporter: Carlin Rogers
>     Assignee: Carlin Rogers
>     Priority: Minor
>      Fix For: V1
>  Attachments: j880-patch.txt
>
> URLTemplate.format(true) leaves a trailing "?" in the following case when the last token
> (url:queryString) is left unset. Technically speaking this should not matter, but some
apps
> break if they are relying on query strings, but not checking zero length query strings.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message