beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlin Rogers (JIRA)" <beehive-...@incubator.apache.org>
Subject [jira] Updated: (BEEHIVE-842) netui:attribute's on the checkBoxOption tag are not being set or overriden
Date Thu, 21 Jul 2005 16:04:59 GMT
     [ http://issues.apache.org/jira/browse/BEEHIVE-842?page=all ]

Carlin Rogers updated BEEHIVE-842:
----------------------------------

    Attachment: j842-patch.zip

The attached zip file has the patch containing some of the
changes that Krista provided. Thanks Krista, nice job!. The
patch also contains the files to support two tests for the
attribute tag. The first test covers setting custom attributes
and overriding others for the various NetUI HTML tags. The
other test is the same but checks error conditions in
addition.

Krista, I did not include your changes to handle "labelstyle",
"lablestyleclass", and "styleclass".

I don't think we want to get into the habit of morphing names of
attributes using the attribute tag, having to then check for case,
etc.

Granted we do have a couple of special conditions we do handle,
like class and style, I feel we should stay close to the intent
of the attribute tag and write out the given name, value pair
on the tag it is within. Users can still set the style and class
of the nested span element using the defined labelStyle and
lableStyleClass attributes of the checkBoxOption and
radioButtonOption. We avoid morphing names of attributes and
differences in lower case vs camel case.

Same thing with "styleclass". I feel that if a user creates an
attribute tag with the name "styleclass" then there should
be an attribute of that name. The special handling for "class"
and "style" is for the fact that those are attributes
on the core HTML tags. The name "styleclass" is just our
own attribute for our own tag. I view overriding our tags as
different from the attribute of the HTML tag.

Sound OK?

> netui:attribute's on the checkBoxOption tag are not being set or overriden
> --------------------------------------------------------------------------
>
>          Key: BEEHIVE-842
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-842
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: v1m1, V1Beta, V1Alpha
>     Reporter: Krista Baker
>     Assignee: Carlin Rogers
>      Fix For: V1
>  Attachments: Controller.java, J842_patch1.txt, index.jsp, j842-patch.zip
>
> Attributes added to the netui:checkBoxOption tag in the jsp are not rendered in the html.
> Example:
> <netui:checkBoxOption value="${pageFlow.optionOne}">
>      <netui:attribute name="anotherCustomAttr" value="anotherCustomValue"/>
> </netui:checkBoxOption>
> Expected Result:
> <input type="checkbox" name="wlw-checkbox_group_key:{actionForm.checkedBoxes}" anotherCustomAttr="anotherCustomValue"><span>One</span>
> Actual Result:  Same as though no attributes were set:
> <input type="checkbox" name="wlw-checkbox_group_key:{actionForm.checkedBoxes}"><span>One</span>
> Will attach a broader repro that includes attributes which are not allowed, attributes
that override in-tag attributes, and custom attributes.
> Attributes which are not allowed to be overridden by using setAttribute/<netui:attribute>'s
do cause a tag error as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message