beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Krista Baker (JIRA)" <beehive-...@incubator.apache.org>
Subject [jira] Updated: (BEEHIVE-842) netui:attribute's on the checkBoxOption tag are not being set or overriden
Date Thu, 14 Jul 2005 22:26:14 GMT
     [ http://issues.apache.org/jira/browse/BEEHIVE-842?page=all ]

Krista Baker updated BEEHIVE-842:
---------------------------------

    Attachment: J842_patch1.txt

Attached file: J842_patch1.txt that should fix several issues with using / setting attributes
on other tags.  

The areas of concern that I have with the attribute setting and this patch are: 1)  it should
say somewhere in the attribute tag docs that the attribute names need to be in all lower case
(since netui typically uses camelCase for most of its attributes) or change the name.equals
comparisons to ignore case.  I see this being a problem mostly with the labelStyle, labelStyleClass,
and styleClass attributes.
2)  If the labelstyle and labelstyleclass constants should not be added to the HtmlConstants.java
(which was done in this patch) they should probably be added into the checkboxoption and radiobuttonoption
classes as constants instead.  

Changes made in J842_patch1:
1)  CheckBoxOption & RadioButtonOption:  these tags now show errors for all attributes
that are not allowed to be overriden.  Errors for Id and name tag errors were not showing
up before.  Also, the else statement after checking to make sure that the name value of the
new attribute wasn't type, checked, or value was disabling the checkbox and returning.  This
did not allow for any attributes to be set on the tags.  The else was modified to check for
DISABLED, LABELSTYLECLASS, and LABELSTYLE and to continue on or return so that the error-handling
and htmlbase attributes can be set.
2)  HtmlConstants.java:  added STYLECLASS into the IHtmlCore properties area as “styleclass”
since that is used in several tags in place of the CLASS=”class” html constant.  Also
added LABELSTYLE and LABELSTYLECLASS into the other attribute constants area for use in CheckBoxOption
and RadioButtonOption as “labelstyle” and labelstyleclass”
3)  SelectOption.java:  returns a tag error now instead of just returning and ignoring an
attribute that had a null name
4)  Base.java:  had two if statements looking for the HREF value, the second one was unnecessary
because the first one would return from the setAttribute method at the if (error).
5)  HtmlBaseTag.java:  Added the STYLECLASS check to the CLASS check so that either one will
obtain the desired result of setting the html tag's class attribute
6)  CheckBox.java:  Updated the DISABLED check to not only allow for a true value.  It now
acts like the others in taking a booleanValue of the string value passed in.
7)  Hidden.java:  should return a tag error now instead of just ignoring an attribute that
had the name set to null
8)  Image.java:  Was not producing the tag error reference, Page Errors were displayed, but
the <img> tag with errors in it was also being displayed.  Added an if hasErrors() statement
to return the reportAndExit(EVAL_PAGE) in the doTag method.

> netui:attribute's on the checkBoxOption tag are not being set or overriden
> --------------------------------------------------------------------------
>
>          Key: BEEHIVE-842
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-842
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: v1m1, V1Beta, V1Alpha
>     Reporter: Krista Baker
>     Assignee: Carlin Rogers
>      Fix For: V1
>  Attachments: Controller.java, J842_patch1.txt, index.jsp
>
> Attributes added to the netui:checkBoxOption tag in the jsp are not rendered in the html.
> Example:
> <netui:checkBoxOption value="${pageFlow.optionOne}">
>      <netui:attribute name="anotherCustomAttr" value="anotherCustomValue"/>
> </netui:checkBoxOption>
> Expected Result:
> <input type="checkbox" name="wlw-checkbox_group_key:{actionForm.checkedBoxes}" anotherCustomAttr="anotherCustomValue"><span>One</span>
> Actual Result:  Same as though no attributes were set:
> <input type="checkbox" name="wlw-checkbox_group_key:{actionForm.checkedBoxes}"><span>One</span>
> Will attach a broader repro that includes attributes which are not allowed, attributes
that override in-tag attributes, and custom attributes.
> Attributes which are not allowed to be overridden by using setAttribute/<netui:attribute>'s
do cause a tag error as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message