beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Feit <richard.f...@bea.com>
Subject Re: checkstyle and code conventions
Date Wed, 08 Jun 2005 03:54:10 GMT
OK, *finally* I get to use the Sun guidelines on my side!  :)  I'm 
really not in favor of using the "I" prefix -- I don't think it's 
necessary or particularly helpful.  But I'd even go with that if others 
-- committers and other community members -- feel strongly about it.  
Can "others" chime in?

Eddie ONeil wrote:

>  On naming interfaces with "I" -- I'd like to see us adopt this as a
>convention going forward -- we definitely have an issue on older
>interfaces.
>
>  Would also like to see us standardize on some naming conventions for
>things "Adapter" vs. "Adaptor" so that we're not divergent across
>Beehive sub-components.
>
>  As long as TODO can be "todo" (is just case-insensitive), I'm good
>with it.  No reason to yell.
>
>  :)
>
>
>
>
>On 6/7/05, Richard Feit <richard.feit@bea.com> wrote:
>  
>
>>(I've pasted in Daryl's reply below, just so we're all in the same thread.)
>>
>>For full disclosure, I really dislike braces on the same line (as
>>opposed to braces on newlines).  But unless there's a groundswell in
>>favor of changing it, we have Sun, Daryl and Eddie all arguing for it.
>>So I'll learn to live with it -- I'm basically throwing away *all* my
>>favorite style quirks -- e.g, 'extraneous' spaces and braces on newlines
>>-- in the interest of us having consistent code.
>>
>>Beyond that, I would agree with everything below, except:
>>
>>    [9] I think we should nix enforcing the 'I' prefix for interfaces
>>until we're at a point where we can deprecate/replace the current ones
>>(e.g., LoginHandler or Validatable) that don't conform to it.  I'm not a
>>fan of this convention anyway, but it doesn't seem like a reasonable
>>option at this point since it changes public APIs.
>>
>>    [10.5.4] I agree with using TODO instead of Fixme, but I think this
>>should be TODO:, not @TODO:, unless @TODO is an actual annotation.
>>
>>I'd also add:
>>    [10.5.1] We should make an exception for && and ||, which I believe
>>are the lowest-precedence operators -- we shouldn't be required to use
>>extra parentheses like this:
>>        if ((a == b) && (c == d))
>>
>>Other thoughts?
>>
>>Rich
>>
>>    
>>
>>>I'm not voting for this, but there is a few additions:
>>>
>>>[4] I think we tend to have line lengths of greater than 80, I think
>>>something like 100 or 120 is reasonable.
>>>[6.3] I agree that we should allow declaration before use and not
>>>require them to be defined at the top of blocks.
>>>
>>>[9] We name interfaces with a 'I' at the beginning of them...
>>>[9] We very commonly use '_' at the start of variables that are module
>>>level variables (which are private and sometimes protected)
>>>
>>>[10.5.2] Totally disagree with this one....return (boolean expression) is great
>>>[10.5.4] We us @TODO: instead of Fixme.
>>>
>>>And the one style (religion here) that I really dislike is [7.4].  I think that
>>>} else {
>>>
>>>should always be done as
>>>}
>>>else {
>>>
>>>and that [7.9] should be
>>>
>>>try {
>>>....
>>>}
>>>catch () {
>>>}
>>>
>>>I think this actually agrees with the readability and space
>>>requirements in the spec.
>>>
>>>      
>>>
>>Eddie ONeil wrote:
>>
>>    
>>
>>> I can mostly live with what has been proposed so far and agree with
>>>Daryl about curly braces / line breaks and such.  The one thing I
>>>can't do is this:
>>>
>>> if ( i == 4 ) {
>>>   ...
>>> }
>>>
>>>All the extraneous spaces just drive me nuts.  :)
>>>
>>>We also need to allow for the use of "_" as a prefix to variable names.
>>>
>>>I'm not sure about enforcing this on checkin, that's something the
>>>committers would need to vote on as well.  CheckStyle has value even
>>>if it's not a checkin blocker.  But, it should definitely be run
>>>before submitting a patch.  It certainly can't block checkin until all
>>>of the code conforms to a standard, and that will take some time.
>>>
>>>But, I can live with the Sun convention plus some tweaks as described
>>>in the thread.
>>>
>>>Eddie
>>>
>>>
>>>
>>>
>>>
>>>On 6/7/05, Chad Schoettger <chad.schoettger@gmail.com> wrote:
>>>
>>>
>>>      
>>>
>>>>I wouldn't mind checkstyle and coding conventions.
>>>>
>>>>#1 - I'm not exactly sure what you me by 'enforce' - if a class comes
>>>>up with checkstyle errors could you still commit it or would the
>>>>commit be blocked until the errors were resolved?
>>>>
>>>>I'm not sure if blocking would be possible with checkstyle -- if it
>>>>was we might be able to avoid some of the pain of what struts was
>>>>going through to get rid of the checkstyle messages. I tend to favor
>>>>this approach since it makes the committer who has made the changes
>>>>responsible for following the coding style.
>>>>
>>>>#2 - that sounds fine.  I think we need to start with something and
>>>>that doesn't seem to be a bad set to start with.
>>>>
>>>>#3 - that sounds reasonable -- once the beehive code conforms to a
>>>>given style it should still be possible to change it.  I would suggest
>>>>that those who vote for a change to the style be the ones to update
>>>>the code to conform to it.
>>>>
>>>>
>>>> - Chad
>>>>
>>>>On 6/7/05, Richard Feit <richard.feit@bea.com> wrote:
>>>>
>>>>
>>>>        
>>>>
>>>>>OK, are we ready to delve into this?  I'm all for it, and I'm hoping we
>>>>>can come to agreement.  I propose that we take the Sun conventions as a
>>>>>starting point, with the mods Jeremiah suggested.  This isn't an
>>>>>official vote... just wondering how people feel about the following:
>>>>>
>>>>>   1) Do we want to enforce code conventions?
>>>>>
>>>>>   2) Do we want to start with the Sun conventions + Jeremiah's mods?
>>>>>
>>>>>   3) Could we work this by proposing changes, and then using the Sun
>>>>>conventions as a fallback if there's are irreconcilable differences?
>>>>>Note that this may cause us to end up with my *most detested* coding
>>>>>convention, but I'm not going to say what it is yet.  ;)
>>>>>
>>>>>Rich
>>>>>
>>>>>Jeremiah Johnson wrote:
>>>>>
>>>>>
>>>>>
>>>>>          
>>>>>
>>>>>>It looks to me like Struts is using the default rules for Checkstyle.
>>>>>>Here is the Struts Checkstyle task in build.xml:
>>>>>>
>>>>>>  <target name="checkstyle" if="checkstyle.jar"
>>>>>>          description="Checks source code against Sun coding
>>>>>>guidelines"
>>>>>>          depends="init">
>>>>>>      <taskdef name="checkstyle"
>>>>>>
>>>>>>classname="com.puppycrawl.tools.checkstyle.CheckStyleTask">
>>>>>>          <classpath location="${checkstyle.jar}"/>
>>>>>>      </taskdef>
>>>>>>      <checkstyle>
>>>>>>          <formatter type="plain"/>
>>>>>>          <fileset dir="${src.share.dir}" includes="**/*.java"/>
>>>>>>      </checkstyle>
>>>>>>  </target>
>>>>>>
>>>>>>Recent check-in comments give some clues to the pain involved: "Fix a
>>>>>>few hundred Checkstyle problems." and "Start fixing our myriad
>>>>>>Checkstyle errors. It seems we've become rather sloppy."
>>>>>>
>>>>>>Heh.
>>>>>>
>>>>>>Apache Jakarta defaults to Sun, but does appear open to defining other
>>>>>>conventions within a project
>>>>>>(http://jakarta.apache.org/site/source.html).  I am guessing that
>>>>>>Beehive would be related to Jakarta after incubation, so it may be a
>>>>>>good time to start addressing coding conventions.
>>>>>>
>>>>>>I attached an example of the type of output Beehive might see if
>>>>>>Checkstyle becomes integrated.  This isn't a perfect example (because I
>>>>>>didn't exclude .svn directories and I used a v3.5 which doesn't support
>>>>>>Java 5), but I believe that by looking at the output you can get an idea
>>>>>>of the kind of stuff you might see.
>>>>>>
>>>>>>To generate the attached, I used the following command:
>>>>>>Java -jar ~/tools/checkstyle-3.5/checkstyle-all-3.5.jar -c
>>>>>>~/tools/checkstyle-3.5/sun_checks.xml -r wsm/src -o wsm-checkstyle.txt
>>>>>>
>>>>>>The developers need to decide if code conventions will be defined now or
>>>>>>later and then what they will be.  I think that you should bite this
>>>>>>bullet now - just after a release - rather than later which may
>>>>>>potentially be just before a release.
>>>>>>
>>>>>>I think that you should modify the Sun conventions.  For example, here
>>>>>>is a suggested place to start (mods to
>>>>>>http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html):
>>>>>>2.2: adjust the list to README.txt
>>>>>>3.1.1: adjust to the current ASF header
>>>>>>4: explicitly defined indentation as 4 spaces
>>>>>>6.3: change to wait to declare variable until block where used
>>>>>>
>>>>>>- jeremiah
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>            
>>>>>>
>>>>>>>-----Original Message-----
>>>>>>>From: Steven Tocco
>>>>>>>Sent: Monday, June 06, 2005 11:13 AM
>>>>>>>To: Beehive Developers
>>>>>>>Subject: RE: reformatting the wsm code
>>>>>>>
>>>>>>>I think this is awesome.  Would love to see some energy around
>>>>>>>checkstyle (or similar tool).
>>>>>>>
>>>>>>>One of the hardest parts about getting checkstyle rolled out is
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>              
>>>>>>>
>>>>>>getting
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>            
>>>>>>
>>>>>>>agreement on the style xml config file, which enforces the rules via
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>              
>>>>>>>
>>>>>>reg
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>            
>>>>>>
>>>>>>>expressions and other rules.  People get so excited about the
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>              
>>>>>>>
>>>>>>placement
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>            
>>>>>>
>>>>>>>of braces in these types of discussions. :)
>>>>>>>
>>>>>>>If I remember correctly it comes with an implementation of the Sun
>>>>>>>coding standard (which might be a little overboard).
>>>>>>>
>>>>>>>Perhaps the struts one would be a good starting place?
>>>>>>>
>>>>>>>Thoughts?
>>>>>>>
>>>>>>>Thanks
>>>>>>>Steve
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>              
>>>>>>>
>>>>>>------------------------------------------------------------------------
>>>>>>
>>>>>>Starting audit...
>>>>>>/home/jjohnson/projects/beehive/wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/package.html:0: Missing package documentation file.
>>>>>>Missing package documentation file.
>>>>>>/home/jjohnson/projects/beehive/wsm/src/api/javax/jws/package.html:0: Missing package documentation file.
>>>>>>/home/jjohnson/projects/beehive/wsm/src/runtime/org/apache/beehive/wsm/axis/security/package.html:0: Missing package documentation file.
>>>>>>/home/jjohnson/projects/beehive/wsm/src/runtime/org/apache/beehive/wsm/processor/apt/package.html:0: Missing package documentation file.
>>>>>>/home/jjohnson/projects/beehive/wsm/src/runtime/org/apache/beehive/wsm/axis/databinding/package.html:0: Missing package documentation file.
>>>>>>wsm/src/api/javax/jws/WebResult.java:0: File does not end with a newline.
>>>>>>wsm/src/api/javax/jws/HandlerChain.java:0: File does not end with a newline.
>>>>>>wsm/src/api/javax/jws/Oneway.java:0: File does not end with a newline.
>>>>>>wsm/src/api/javax/jws/WebService.java:0: File does not end with a newline.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/axis/util/encoding/XmlBeanDeserializer.java:0: File does not end with a newline.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/axis/handlers/AnnotatedWebServiceDeploymentHandler.java:0: File does not end with a newline.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/databinding/BindingLookupService.java:0: File does not end with a newline.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsSOAPMessageHandlerInfo.java:0: File does not end with a newline.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/Jsr181MethodMetadataImpl.java:0: File does not end with a newline.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/Jsr181ParameterMetadataImpl.java:0: File does not end with a newline.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:0: File does not end with a newline.
>>>>>>wsm/src/api/javax/jws/WebResult.java:23:1: Got an exception - unexpected char: '@'
>>>>>>wsm/src/api/javax/jws/HandlerChain.java:23:1: Got an exception - unexpected char: '@'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/ProcessorException.java:9: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/ProcessorException.java:11: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/ProcessorException.java:28: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/ProcessorException.java:29:31: Parameter msg should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/ProcessorException.java:29:43: Parameter e should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/ProcessorException.java:33:31: Parameter msg should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/ProcessorException.java:37:31: Parameter e should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/WebServiceMetadataViewer.java:75:13: Got an exception - expecting EOF, found '}'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/MirrorMethodInfo.java:45:9: Got an exception - expecting EOF, found '}'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/WsmAnnotationProcessor.java:54:9: Got an exception - expecting EOF, found 'oms'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TwoPhaseAnnotationProcessor.java:73:9: Got an exception - expecting EOF, found '_env'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/WsmAnnotationProcessorFactory.java:52:5: Got an exception - expecting EOF, found '}'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/MirrorParameterInfo.java:75:5: Got an exception - expecting EOF, found '}'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:26:1: Utility classes should not have a public or default constructor.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:29:38: Parameter type should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:35:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:36:59: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:37:13: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:38:20: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:40:13: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:41:20: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:43:56: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:45:20: 'for' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:48:60: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:49:19: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:51: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:51:86: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:52:17: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:55: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:55:63: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:58:13: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:62:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:63:14: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:69:44: Parameter kind should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:72:9: switch without "default" clause.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:94: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:94:59: Parameter kind should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:97:9: switch without "default" clause.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:119: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:119:35: Parameter type should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:119:51: Parameter depth should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:119:62: Parameter typeOfArray should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:120:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:121: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:121:42: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:122:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:138: Expected an @return tag.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:138:36: Parameter className should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:138:43: Expected @param tag for 'className'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:139:16: Expected @throws tag for 'ClassNotFoundException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:142:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:144:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:148:13: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:149:18: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:151:20: 'for' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/TypeMirrorUtil.java:152:23: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/processor/apt/MirrorTypeInfo.java:48:9: Got an exception - expecting EOF, found '}'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:2: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:4: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:5: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:17: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:18: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:40:19: Variable 'logger' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:42:27: Variable 'mTypeMapping' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:44:36: Variable 'lookupService' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:50: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:50:26: Parameter typeMapping should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:50:38: Expected @param tag for 'typeMapping'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:50:51: Parameter lookupService should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:50:72: 'lookupService' hides a field.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:50:72: Expected @param tag for 'lookupService'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:60:55: Expected @param tag for 'cls'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:66:14: 'protected' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:66:76: Expected @param tag for 'cls'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:67:76: Expected @param tag for 'q'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:68: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:68:88: Expected @param tag for 'style'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:69: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:69:86: Expected @param tag for 'use'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:75:14: 'protected' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:75:59: Expected @param tag for 'cls'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:75:70: Expected @param tag for 'q'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:86:14: 'protected' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:86:62: Expected @param tag for 'cls'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:86:73: Expected @param tag for 'q'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:87:16: Expected @throws tag for 'ClassNotFoundException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:88:9: Expected @throws tag for 'NoSuchMethodException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:89:9: Expected @throws tag for 'InstantiationException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:90:9: Expected @throws tag for 'IllegalAccessException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:91:9: Expected @throws tag for 'InvocationTargetException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:97:14: 'protected' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:97:67: Expected @param tag for 'cls'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:97:78: Expected @param tag for 'q'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:104:14: 'protected' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:104:56: Expected @param tag for 'cls'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:104:67: Expected @param tag for 'q'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:109:14: 'public' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:111:14: 'protected' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:113:14: 'protected' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:115:5: Method 'registerType' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:115:31: Parameter cls should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:115:42: Parameter style should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:116:31: Parameter use should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:118:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:120:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:127: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:127:5: Method 'registerType' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:127:31: Parameter cls should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:127:42: Parameter q should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:127:51: Parameter style should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:127:76: Parameter use should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:129: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:131: 'if' construct must use '{}'s.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:131:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:134: 'if' construct must use '{}'s.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:134:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:136: 'if' construct must use '{}'s.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:136:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:140:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:141:19: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:143: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:144: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:145: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:146: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:147: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:148: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:150: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:152: 'if' construct must use '{}'s.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:152:23: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:157:13: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:158:20: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:160:19: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:162:17: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:167:24: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:173:21: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:174:26: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:181:17: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:192: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:192:24: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:193: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:194:17: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:202: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:204:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:205:14: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:220: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:221:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:222:14: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:222:28: Must have at least one statement.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:227:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:229: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:230:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:231:14: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:231:28: Must have at least one statement.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:239: Expected an @return tag.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:239:12: 'public' modifier out of order with the JLS suggestions.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:239:46: Parameter t should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:239:51: Expected @param tag for 't'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:242:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:243:55: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:245:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:245:60: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:247:19: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:248: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:248:53: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:248:72: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:250:17: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:252:34: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:254:13: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:256: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:259:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:260:16: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:261:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:261:53: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:264:48: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:265:20: 'for' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:266:23: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:271:13: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/registration/TypeRegistrar.java:273: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/axis/AxisHook.java:93:9: Got an exception - expecting EOF, found 'for'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/axis/registration/AxisTypeMappingMetaData.java:28:5: Got an exception - expecting EOF, found '}'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/axis/registration/AxisTypeRegistrar.java:106:17: Got an exception - expecting EOF, found 'if'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/axis/databinding/SystemTypeLookupService.java:36:9: Got an exception - expecting EOF, found 'lookupServiceList'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/axis/databinding/AxisTypeLookup.java:2: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:109:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:111: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:111:80: Avoid inline conditionals.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:116:5: Method 'equals' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:116:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:116:27: Parameter o should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:117:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:118:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:119:56: 'cast' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/SOAPBindingInfo.java:121: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:8: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:10: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:22: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:25:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:27:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:27:12: Variable 'name' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:28:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:28:12: Variable 'value' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:33:26: Parameter a should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:33:36: Expected @param tag for 'a'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:41:37: Parameter a should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:41:47: Expected @param tag for 'a'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:42:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:52:5: Method 'getName' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:59:5: Method 'setName' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:59:25: Parameter name should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:59:32: 'name' hides a field.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:66:5: Method 'getValue' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:73:5: Method 'setValue' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:73:26: Parameter value should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InitParamInfo.java:73:33: 'value' hides a field.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/Jsr181MethodMetadataImpl.java:57:5: Got an exception - expecting EOF, found '}'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:9: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:11: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:21: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:24:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:27: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:36:28: Parameter arg0 should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:36:35: Expected @param tag for 'arg0'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:44:28: Parameter arg0 should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:44:35: Expected @param tag for 'arg0'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:44:41: Parameter arg1 should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:44:51: Expected @param tag for 'arg1'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:51:28: Parameter arg0 should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/InvalidFileType.java:51:38: Expected @param tag for 'arg0'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/jsr181/Jsr181ParameterMetadataImpl.java:72:17: Got an exception - expecting EOF, found '}'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/wsdl/XmlBeanWSDLProcessor.java:99:9: Got an exception - expecting EOF, found 'TDefinitions'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:7: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:9: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:27:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:29:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:31:13: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:33:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:35:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:37:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:47: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:47:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:49:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/model/BeehiveWsParameterMetadata.java:51:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/Schema.java:68:17: Got an exception - expecting EOF, found 'break'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:33: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:35:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:35:17: Variable 'stream' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:36:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:36:25: Variable 'defDoc' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:37:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:37:12: Variable 'tt' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:38:5: Missing a Javadoc comment.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:38:12: Variable 'schema' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:39:16: Variable 'services' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:46:23: Parameter stream should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:46:35: 'stream' hides a field.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:46:35: Expected @param tag for 'stream'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:47: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:47:16: Expected @throws tag for 'XmlException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:47:16: Unable to get class information for XmlException.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:47:30: Expected @throws tag for 'IOException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:47:43: Expected @throws tag for 'IllegalAccessException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:47:67: Expected @throws tag for 'NoSuchFieldException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:61:5: Method 'getSchema' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:65:5: Method 'getSoapAddressLocation' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:68:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:70:15: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:72: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:73:23: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:76:17: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:77:22: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLParser.java:77:47: Must have at least one statement.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/Utilities.java:42:9: Got an exception - expecting EOF, found 'XmlObject'
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:3: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:5: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:6: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:42:20: Variable 've' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:43:14: Variable 'template' must be private and have accessor methods.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:52:16: Expected @throws tag for 'Exception'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:62:5: Method 'init' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:63:16: Expected @throws tag for 'Exception'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:63:27: Expected @throws tag for 'ResourceNotFoundException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:63:27: Unable to get class information for ResourceNotFoundException.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:64:9: Expected @throws tag for 'ParseErrorException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:64:9: Unable to get class information for ParseErrorException.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:64:30: Expected @throws tag for 'MethodInvocationException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:64:30: Unable to get class information for MethodInvocationException.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:76:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:77:14: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:84:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:85:14: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:89:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:90:14: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:95:9: '}' should be on the same line.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:96:14: 'catch' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:102: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:102:5: Method 'generateAnnotatedJavaFromWSDL' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:102:47: Parameter wsdlFileName should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:102:68: Parameter baseSrcDir should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:115: 'if' construct must use '{}'s.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:115:11: 'if' is not followed by whitespace.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:118: Line is longer than 80 characters.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:126:5: Method 'generateAnnotatedJavaFromWSDL' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:126:47: Parameter wsdl should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:126:65: Parameter w should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:141:5: Method 'generateAnnotatedJavaFromOM' is not designed for extension - needs to be abstract, final or empty.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:141:45: Parameter om should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:141:67: Expected @param tag for 'om'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:141:71: Parameter w should be final.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:141:78: Expected @param tag for 'w'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:142:16: Expected @throws tag for 'ResourceNotFoundException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:142:16: Unable to get class information for ResourceNotFoundException.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:142:43: Expected @throws tag for 'ParseErrorException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:142:43: Unable to get class information for ParseErrorException.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:143:9: Expected @throws tag for 'MethodInvocationException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:143:9: Unable to get class information for MethodInvocationException.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:143:36: Expected @throws tag for 'Exception'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:143:47: Expected @throws tag for 'IOException'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/AbstractWsdl2AJava.java:143:47: Redundant throws: 'IOException' is subclass of 'Exception'.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLProcessor.java:3: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLProcessor.java:5: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLProcessor.java:6: Line has trailing spaces.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLProcessor.java:40:5: Redundant 'public' modifier.
>>>>>>wsm/src/runtime/org/apache/beehive/wsm/wsdl/WSDLProcessor.java:41:16: Expected @throws tag for 'Exception'.
>>>>>>Audit done.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>            
>>>>>>
>>>
>>>      
>>>
>
>  
>

Mime
View raw message