beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rich Feit (JIRA)" <>
Subject [jira] Updated: (BEEHIVE-835) Make improvements to the support for URL templating.
Date Mon, 27 Jun 2005 19:49:57 GMT
     [ ]

Rich Feit updated BEEHIVE-835:

    Assign To: Carlin Rogers  (was: Rich Feit)

Thanks Carlin -- these changes look good to me.  I committed them with revision 202040.  I'm
leaving the bug open to discuss three things -- let me know what you think.

1) Could DefaultTemplatedURLFormatter and DefaultURLTemplatesFactory be implicit if you call
their respective initServletContext methods with a null value?  Seems like the default implementations
should be chosen down in the core layer, if those implementations live in the core layer.

2) I changed the implementation of DefaultServletContainerAdapter.getFactory() to assume that
it's a programming error to call it with a Class that's not assignable to Factory.  But beyond
that, does there really need to be an implementation of getFactory in DefaultServletContainerAdapter?
 Seems like this could be omitted (replaced with an empty implementation), since we already
infer DefaultURLTemplatesFactory.

3) In netui-config.xsd could there be a default value for templated-url-formatter-class?

> Make improvements to the support for URL templating.
> ----------------------------------------------------
>          Key: BEEHIVE-835
>          URL:
>      Project: Beehive
>         Type: Improvement
>   Components: NetUI
>     Versions: V1Alpha, V1Beta, v1m1
>     Reporter: Carlin Rogers
>     Assignee: Carlin Rogers
>      Fix For: V1
>  Attachments: j835-patch.txt
> These changes are based on the discussions from email I posted 
> to the list. See...
> and
> In summary...
> - deprecate URLTemplateDescriptor and just use the URLTemplatesFactory 
> to get a URLTemplate.
> - create a hook via the ServletContainerAdapter  to support container 
> specific implementations of URLTemplatesFactory (extending Factory) for 
> reading/parsing the beehive-url-template-config.xml descriptor file. 
> - after loading the URLTemplatesFactory  instance, set it as an 
> attribute on the ServletContext so TemplatedURLFormatter 
> implementations can get the desired URLTemplate when formatting a
> rewritten URL.
> - add an element to the beehive-netui-config schema to allow for a
> class name of a per-webapp TemplatedURLFormatter to be used by the
> URLRewriterService if there is not a per-request registered 
> TemplatedURLFormatter.
> - add this default TemplatedURLFormatter instance to the
> ServletContext for the URLRewriterService.
> And other minor modifications...
> - change TemplateTokenizer to accept more general token (I.e. "url:"
> is not required as part of the token string).
> - when formatting the URL with a template, if there is now replacement
> value for a token, use the empty string.
> - go back to "jpf-url-templates" as the name of the default template 
> ref group rather than "default-url-templates".

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message