beehive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremiah Johnson" <>
Subject RE: [jira] Assigned: (BEEHIVE-525) Need JavaDoc for the Jpf annotation interface
Date Mon, 16 May 2005 14:48:12 GMT
Sorry that I didn't get back to you on this last night.

> >ActionOuptut
> >-	the summary isn't clear to me; is that accurate about the
> ConditionalForward?  I would suggest something like this: A defined
> output that may be used as a 'page input' in a page (accessed by
> databinding to ${pageInput.action-output-name}.  The benefit of action
> outputs (over setting request attributes) is that you get compile and
> runtime checking with the action outputs.
> >
> >
> Weird -- that was a javadoc bug.  I had {@link Forward}, but it
> a link to ConditionalForward.  I made another attempt -- comments

Heh - I'll take a look.

> >Controller
> >-	add note in summary that there may be only one class with the
> Controller annotation per package
> >
> >
> There can actually be both a page flow and a shared flow in a package.
> I've added the only-one restriction to the docs for PageFlowController
> and SharedFlowController.

Okay, thanks.

> >SharedFlowField
> >-	I don't think that the summary is accurate because I don't think
> that the SharedFlowField can exist withouth a SharedFlowRef;
therefore, it
> isn't really automatic; does this sound okay: An annotation that
> identifies a field as the reference to a SharedFlowController.  The
> annotation initializes the field based on the matching shared flow
> reference in the controller annotation.  A SharedFlowField is only
> if some code needs to explicitly access something in the shared flow
> opposed to some other annotation referring to the shared flow).
> >
> >
> >
> I didn't totally understand the concern you had about "automatic" --
> let's talk about it in person (or IM -- richfeit@YIM).  I did update
> description...

The name element in the SharedFlowField implies that a Jpf.SharedFlowRef
will be needed to use Jpf.SharedFlowField, but it isn't explicitly
stated.  That is what I was trying to do with my reword of the summary.
It isn't bad as it is - just was asking you to consider the reword and I
think that you did - thanks :)  I'll verify no typos and then go close.

- jeremiah

View raw message