Mailing-List: contact user-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@beam.incubator.apache.org
MIME-Version: 1.0
References: <CAOdmQRiCiG09tAubYkq75aUT8qEdXNfCtd0PYmoL16bsMVmT=w@mail.gmail.com>
 <CAA8k_FKJGL_kZTasnwotx+tkWNw7E4N-mCe_VhJDAhrXwg_aVw@mail.gmail.com>
In-Reply-To: <CAA8k_FKJGL_kZTasnwotx+tkWNw7E4N-mCe_VhJDAhrXwg_aVw@mail.gmail.com>
From: Jesse Anderson <jesse@smokinghand.com>
Date: Tue, 07 Jun 2016 16:50:01 +0000
Message-ID: <CAOdmQRhr=Xq9UTNCtYOCEQWdSrbxk6g9BiS5878eNik8BHr2_Q@mail.gmail.com>
Subject: Re: KafkaIO Writer
To: user@beam.incubator.apache.org
Content-Type: multipart/alternative; boundary=001a1141c7aa6f94880534b2fbe2
archived-at: Tue, 07 Jun 2016 16:50:16 -0000

--001a1141c7aa6f94880534b2fbe2
Content-Type: text/plain; charset=UTF-8

Ah the over the weekend part explains that.

Is there a reason KafkaIO doesn't follow the separate classes for read and
write like TextIO does? Following the TextIO style, there should be a
KafkaIO.Read.method() or KafkaIO.Write.method().

On Tue, Jun 7, 2016 at 12:22 PM Dan Halperin <dhalperi@google.com> wrote:

> Hi Jesse,
>
> KafkaIO supports write:
> https://github.com/apache/incubator-beam/blob/master/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java#L161
>
> (This was merged over the weekend as part of @rangadi's
> https://github.com/apache/incubator-beam/pull/271)
>
> Dan
>
> On Tue, Jun 7, 2016 at 9:04 AM, Jesse Anderson <jesse@smokinghand.com>
> wrote:
>
>> Are there plans to add a writer to KafkaIO? Right now, it's only read.
>>
>> The class itself is written to only expect a reader. Adding any sort of
>> write would require refactoring the class to Read and Write like TextIO
>> does.
>>
>> Thanks,
>>
>> Jesse
>>
>
>

--001a1141c7aa6f94880534b2fbe2
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Ah the over the weekend part explains that.<div><br></div>=
<div>Is there a reason KafkaIO doesn&#39;t follow the separate classes for =
read and write like TextIO does? Following the TextIO style, there should b=
e a KafkaIO.Read.method() or KafkaIO.Write.method().</div></div><br><div cl=
ass=3D"gmail_quote"><div dir=3D"ltr">On Tue, Jun 7, 2016 at 12:22 PM Dan Ha=
lperin &lt;<a href=3D"mailto:dhalperi@google.com">dhalperi@google.com</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi Jesse=
,<div><br></div><div>KafkaIO supports write: <a href=3D"https://github.com/=
apache/incubator-beam/blob/master/sdks/java/io/kafka/src/main/java/org/apac=
he/beam/sdk/io/kafka/KafkaIO.java#L161" target=3D"_blank">https://github.co=
m/apache/incubator-beam/blob/master/sdks/java/io/kafka/src/main/java/org/ap=
ache/beam/sdk/io/kafka/KafkaIO.java#L161</a></div><div><br></div><div>(This=
 was merged over the weekend as part of @rangadi&#39;s=C2=A0<a href=3D"http=
s://github.com/apache/incubator-beam/pull/271" target=3D"_blank">https://gi=
thub.com/apache/incubator-beam/pull/271</a>)</div></div><div dir=3D"ltr"><d=
iv><br></div><div>Dan</div></div><div class=3D"gmail_extra"><br><div class=
=3D"gmail_quote">On Tue, Jun 7, 2016 at 9:04 AM, Jesse Anderson <span dir=
=3D"ltr">&lt;<a href=3D"mailto:jesse@smokinghand.com" target=3D"_blank">jes=
se@smokinghand.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quot=
e" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">=
<div dir=3D"ltr">Are there plans to add a writer to KafkaIO? Right now, it&=
#39;s only read.<div><br></div><div>The class itself is written to only exp=
ect a reader. Adding any sort of write would require refactoring the class =
to Read and Write like TextIO does.</div><div><br></div><div>Thanks,</div><=
div><br></div><div>Jesse</div></div>
</blockquote></div><br></div>
</blockquote></div>

--001a1141c7aa6f94880534b2fbe2--