From issues-return-172501-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Jun 25 21:15:02 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 840C8180674 for ; Fri, 25 Jun 2021 23:15:02 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id AE68C3FD75 for ; Fri, 25 Jun 2021 21:15:01 +0000 (UTC) Received: (qmail 76735 invoked by uid 500); 25 Jun 2021 21:15:01 -0000 Mailing-List: contact issues-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list issues@beam.apache.org Received: (qmail 76670 invoked by uid 99); 25 Jun 2021 21:15:01 -0000 Received: from mailrelay1-he-de.apache.org (HELO mailrelay1-he-de.apache.org) (116.203.21.61) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jun 2021 21:15:01 +0000 Received: from jira2-he-de.apache.org (jira2-he-de.apache.org [168.119.33.54]) by mailrelay1-he-de.apache.org (ASF Mail Server at mailrelay1-he-de.apache.org) with ESMTPS id 79A913E8B1 for ; Fri, 25 Jun 2021 21:15:00 +0000 (UTC) Received: from jira2-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira2-he-de.apache.org (ASF Mail Server at jira2-he-de.apache.org) with ESMTP id 248CCC806F5 for ; Fri, 25 Jun 2021 21:15:00 +0000 (UTC) Date: Fri, 25 Jun 2021 21:15:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: issues@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-12513) Complete Go SDK inclusion to Beam Programming Guide MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-12513?focusedWorklogId=615216&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615216 ] ASF GitHub Bot logged work on BEAM-12513: ----------------------------------------- Author: ASF GitHub Bot Created on: 25/Jun/21 21:14 Start Date: 25/Jun/21 21:14 Worklog Time Spent: 10m Work Description: lostluck commented on pull request #15057: URL: https://github.com/apache/beam/pull/15057#issuecomment-868836843 > > R: @youngoli @tysonjh > > Question: What do you think of me consolidating the code example files a bit? I think they should probably not get larger than ~400 lines each, but the small ones are certainly too small. I'm thinking consolidating roughly on size so all the earlier sections would be in pipeline.go, transforms.go would cover section 4, etc. > > This makes sense to me. Does this impact how it will be displayed in docs? E.g. using github snippets If one looked at the GoDoc for the snippet package, no that wouldn't display correctly at all. GoDoc doesn't take file ordering into account everything is sorted by top level name (so methods are grouped with their type as you'd expect). I don't know about github snippets. As for using those snippets in the beam website, the snippets are file origin agnostic, and copied at static site generation, so how they're stored in code doesn't matter. Overall, the code organization is largely cosmetic for the code itself, so the present approach of prefixing with BPG section number means the files will be in the order that match the section whose code they contain. Everything internally is magic comments for the code snippet puller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscribe@beam.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 615216) Time Spent: 4h 20m (was: 4h 10m) > Complete Go SDK inclusion to Beam Programming Guide > --------------------------------------------------- > > Key: BEAM-12513 > URL: https://issues.apache.org/jira/browse/BEAM-12513 > Project: Beam > Issue Type: Improvement > Components: sdk-go > Reporter: Robert Burke > Assignee: Robert Burke > Priority: P2 > Time Spent: 4h 20m > Remaining Estimate: 0h > > BPG Go Audit snapshot: [https://docs.google.com/spreadsheets/d/1DrBFjxPBmMMmPfeFr6jr_JndxGOes8qDqKZ2Uxwvvds/edit?resourcekey=0-tVFwcLrQ2v2jpZkHk6QOpQ#gid=2072310090] > Goal is to include Go SDK code for all missing snippets, and where code can't yet exist, file and link a Jira instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)