beam-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-10961) Enable strict dependency analysis on all Java modules
Date Sun, 10 Jan 2021 04:33:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=533924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533924
]

ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/21 04:32
            Start Date: 10/Jan/21 04:32
    Worklog Time Spent: 10m 
      Work Description: ibzib commented on a change in pull request #13668:
URL: https://github.com/apache/beam/pull/13668#discussion_r554255375



##########
File path: runners/spark/job-server/build.gradle
##########
@@ -49,14 +49,12 @@ configurations.all {
 }
 
 dependencies {
-  compile project(sparkRunnerProject)
   compile project(path: sparkRunnerProject, configuration: "provided")
   validatesPortableRunner project(path: sparkRunnerProject, configuration: "testRuntime")
   validatesPortableRunner project(path: sparkRunnerProject, configuration: "provided")
   validatesPortableRunner project(path: ":sdks:java:core", configuration: "shadowTest")
   validatesPortableRunner project(path: ":runners:core-java", configuration: "testRuntime")
   validatesPortableRunner project(path: ":runners:portability:java", configuration: "testRuntime")
-  compile project(":sdks:java:extensions:google-cloud-platform-core")

Review comment:
       I believe we need this as a runtime-only dependency for the expansion service.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 533924)
    Time Spent: 38h 50m  (was: 38h 40m)

> Enable strict dependency analysis on all Java modules 
> ------------------------------------------------------
>
>                 Key: BEAM-10961
>                 URL: https://issues.apache.org/jira/browse/BEAM-10961
>             Project: Beam
>          Issue Type: Improvement
>          Components: java-fn-execution
>            Reporter: Shehzaad Nakhoda
>            Assignee: Shehzaad Nakhoda
>            Priority: P2
>          Time Spent: 38h 50m
>  Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without depending
on them, or if it has direct dependencies it doesn't use, the build fails. The work involves
adding dependencies or adding exclusion rules (example: https://github.com/wfhartford/gradle-dependency-analyze#configurations).
Even if they just add exclusions across the board, it will be a big win because it will prevent
new violations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message