beam-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-10961) Enable strict dependency analysis on all Java modules
Date Thu, 31 Dec 2020 09:05:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=529735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529735
]

ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Dec/20 09:04
            Start Date: 31/Dec/20 09:04
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #12938:
URL: https://github.com/apache/beam/pull/12938#issuecomment-702062256


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=h1) Report
   > Merging [#12938](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=desc)
(be64412) into [master](https://codecov.io/gh/apache/beam/commit/7ef8bd1d13463c03a28812473e92014fc6b5a3d1?el=desc)
(7ef8bd1) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12938/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12938      +/-   ##
   ==========================================
   - Coverage   82.73%   82.72%   -0.01%     
   ==========================================
     Files         466      466              
     Lines       57514    57514              
   ==========================================
   - Hits        47584    47581       -3     
   - Misses       9930     9933       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=tree) | Coverage
Δ | |
   |---|---|---|
   | [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5)
| `96.49% <0.00%> (-1.76%)` | :arrow_down: |
   | [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5)
| `91.66% <0.00%> (-0.76%)` | :arrow_down: |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12938/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `93.70% <0.00%> (-0.13%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=footer).
Last update [7ef8bd1...aa22d1b](https://codecov.io/gh/apache/beam/pull/12938?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 529735)
    Time Spent: 28h  (was: 27h 50m)

> Enable strict dependency analysis on all Java modules 
> ------------------------------------------------------
>
>                 Key: BEAM-10961
>                 URL: https://issues.apache.org/jira/browse/BEAM-10961
>             Project: Beam
>          Issue Type: Improvement
>          Components: java-fn-execution
>            Reporter: Shehzaad Nakhoda
>            Assignee: Shehzaad Nakhoda
>            Priority: P2
>          Time Spent: 28h
>  Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without depending
on them, or if it has direct dependencies it doesn't use, the build fails. The work involves
adding dependencies or adding exclusion rules (example: https://github.com/wfhartford/gradle-dependency-analyze#configurations).
Even if they just add exclusions across the board, it will be a big win because it will prevent
new violations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message