beam-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-10705) Passing whl files in --sdk_location does not work for https locations.
Date Tue, 15 Sep 2020 17:08:02 GMT

     [ https://issues.apache.org/jira/browse/BEAM-10705?focusedWorklogId=484647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484647
]

ASF GitHub Bot logged work on BEAM-10705:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Sep/20 17:07
            Start Date: 15/Sep/20 17:07
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #12811:
URL: https://github.com/apache/beam/pull/12811#discussion_r488824939



##########
File path: sdks/python/apache_beam/runners/portability/stager_test.py
##########
@@ -448,7 +448,8 @@ def test_sdk_location_remote_source_file(self, *unused_mocks):
   def test_sdk_location_remote_wheel_file(self, *unused_mocks):
     staging_dir = self.make_temp_dir()
     sdk_filename = 'apache_beam-1.0.0-cp27-cp27mu-manylinux1_x86_64.whl'
-    sdk_location = 'https://storage.googleapis.com/my-gcs-bucket/' + sdk_filename
+    sdk_location = 'https://storage.googleapis.com/my-gcs-bucket/' + \

Review comment:
       Nit: implicit line joining (with parenthesis instead of backslash)  is preferable by
PIP8. Since Beam does not officially use PIP8, I will merge as is, just FYI.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 484647)
    Time Spent: 4h 10m  (was: 4h)

> Passing whl files in --sdk_location does not work  for https locations.
> -----------------------------------------------------------------------
>
>                 Key: BEAM-10705
>                 URL: https://issues.apache.org/jira/browse/BEAM-10705
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Assignee: Ayoub Ennassiri
>            Priority: P3
>              Labels: starter
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Sample repro:
> python -m apache_beam.examples.wordcount --input=gs://dataflow-samples/shakespeare/kinglear.txt
--output /tmp/wordcount  --runner=DataflowRunner --project=google.com:clo
> uddfe --temp_location gs://clouddfe-valentyn/tmp/ --region=us-central1 --sdk_location=https://
> storage.googleapis.com/beam-wheels-staging/master/94f9e7fd4cae0f8aa6587d2cf14887f1c4827485-198
> 203585/apache_beam-2.24.0.dev0-cp27-cp27m-macosx_10_9_x86_64.whl
> {noformat}
>   File "/home/valentyn/.pyenv/versions/3.7.3/lib/python3.7/runpy.py", line 193, in _run_module_as_main
>     "__main__", mod_spec)
>   File "/home/valentyn/.pyenv/versions/3.7.3/lib/python3.7/runpy.py", line 85, in _run_code
>     exec(code, run_globals)
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/examples/wordcount.py",
line 99, in <module>
>     run()
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/examples/wordcount.py",
line 94, in run
>     output | 'Write' >> WriteToText(known_args.output)
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/pipeline.py",
line 555, in __exit__
>     self.result = self.run()
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/pipeline.py",
line 521, in run
>     allow_proto_holders=True).run(False)
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/pipeline.py",
line 534, in run
>     return self.runner.run_pipeline(self, self._options)
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py",
line 479, in run_pipeline
>     artifacts=environments.python_sdk_dependencies(options)))
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/transforms/environments.py",
line 613, in python_sdk_dependencies
>     staged_name in stager.Stager.create_job_resources(options, tmp_dir))
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/runners/portability/stager.py",
line 235, in create_job_resources
>     resources.extend(Stager._create_beam_sdk(sdk_remote_location, temp_dir))
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/runners/portability/stager.py",
line 659, in _create_beam_sdk
>     sdk_remote_location)
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/runners/portability/stager.py",
line 596, in _desired_sdk_filename_in_staging_location
>     _, wheel_filename = FileSystems.split(sdk_location)
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/io/filesystems.py",
line 151, in split
>     filesystem = FileSystems.get_filesystem(path)
>   File "/home/valentyn/projects/beam/beam2/beam/sdks/python/apache_beam/io/filesystems.py",
line 106, in get_filesystem
>     'e.g., pip install apache-beam[gcp]. Path specified: %s' % path)
> ValueError: Unable to get filesystem from specified path, please use the correct path
or ensure the required dependency is installed, e.g., pip install apache-beam[gcp]. Path specified:
https://storage.googleapis.com/beam-wheels-staging/master/94f9e7fd4cae0f8aa6587d2cf14887f1c4827485-198203585/apache_beam-2.24.0.dev0-cp27-cp27m-macosx_10_9_x86_64.whl
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message