beam-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-9747) Deprecate RedisIO.readAll() and add RedisIO.readKeyPatterns() as a replacement
Date Tue, 30 Jun 2020 22:30:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-9747?focusedWorklogId=453148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453148
]

ASF GitHub Bot logged work on BEAM-9747:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jun/20 22:29
            Start Date: 30/Jun/20 22:29
    Worklog Time Spent: 10m 
      Work Description: n3lsok commented on a change in pull request #11405:
URL: https://github.com/apache/beam/pull/11405#discussion_r448014725



##########
File path: sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##########
@@ -123,8 +123,24 @@ public static Read read() {
    * Like {@link #read()} but executes multiple instances of the Redis query substituting
each
    * element of a {@link PCollection} as key pattern.
    */
-  public static ReadAll readAll() {
-    return new AutoValue_RedisIO_ReadAll.Builder()
+  public static ReadKeyPatterns readKeyPatterns() {
+    return new AutoValue_RedisIO_ReadKeyPatterns.Builder()
+        .setConnectionConfiguration(RedisConnectionConfiguration.create())
+        .setBatchSize(1000)
+        .setOutputParallelization(true)
+        .build();
+  }
+
+  /**
+   * Like {@link #read()} but executes multiple instances of the Redis query substituting
each
+   * element of a {@link PCollection} as key pattern.
+   *
+   * @deprecated This method is not consistent with the readAll pattern of other transforms
and will
+   *     be remove soon. Please update you code to use {@link #readKeyPatterns()} instead.
+   */
+  @Deprecated
+  public static ReadKeyPatterns readAll() {

Review comment:
       Hello! how can I to use this version ?? I cant' see how to compile and to use with
an development which I have problems using RedisIO.readAll(), as I see this versión solved
this issue. Please your help, All the best!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 453148)
    Time Spent: 2h  (was: 1h 50m)

> Deprecate RedisIO.readAll() and add RedisIO.readKeyPatterns() as a replacement
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-9747
>                 URL: https://issues.apache.org/jira/browse/BEAM-9747
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-redis
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: P3
>             Fix For: 2.23.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> The current RedisIO.ReadAll transform does not follow the ReadAll pattern
> introduced by other IOs like HBaseIO, SolrIO and soon CassandraIO. We should
> change current ReadAll into ReadKeyPatterns to avoid confusion to be able to provide
a
> consistent ReadAll transform BEAM-9403



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message