beam-github mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] usingh83 commented on a change in pull request #14902: Twitter redesign to move the component to it's separate project.
Date Fri, 04 Jun 2021 07:47:08 GMT

usingh83 commented on a change in pull request #14902:
URL: https://github.com/apache/beam/pull/14902#discussion_r644270760



##########
File path: examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/README.md
##########
@@ -34,6 +34,7 @@ This directory contains an example pipelines for how to perform continues
stream
 
 - Java 8
 - Twitter developer app account and streaming credentials.
+- Direct runner or Flink runner.

Review comment:
       No, i haven't added the support for AutoValue, my understanding is that without that
the code will not run on Dataflow. And also for the twitter api to run in dataflow, i will
need to the twitter app credentials to be passable from command line.

##########
File path: examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/README.md
##########
@@ -34,6 +34,7 @@ This directory contains an example pipelines for how to perform continues
stream
 
 - Java 8
 - Twitter developer app account and streaming credentials.
+- Direct runner or Flink runner.

Review comment:
       No, i haven't added the support for AutoValue, my understanding is that without that
the code will not run on Dataflow. And also for the twitter api to run in dataflow, i will
need the twitter app credentials to be passable from command line.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message