beam-github mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] lazylynx commented on a change in pull request #14730: [BEAM-7372][BEAM-9372] Cleanup py2 and py35 codepath from runners worker
Date Thu, 13 May 2021 13:59:47 GMT

lazylynx commented on a change in pull request #14730:
URL: https://github.com/apache/beam/pull/14730#discussion_r631831672



##########
File path: sdks/python/apache_beam/runners/worker/data_plane.py
##########
@@ -639,6 +640,13 @@ def create_data_channel(self, remote_grpc_port):
     """Returns a ``DataChannel`` from the given RemoteGrpcPort."""
     raise NotImplementedError(type(self))
 
+  @abc.abstractmethod
+  def create_data_channel_from_url(self, remote_grpc_port):

Review comment:
       That's true! Replaced at ce9fb38 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message