beam-github mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] lostluck commented on a change in pull request #14513: Allow the declaration of runner capabilities over FnAPI.
Date Wed, 14 Apr 2021 16:27:27 GMT

lostluck commented on a change in pull request #14513:
URL: https://github.com/apache/beam/pull/14513#discussion_r613398324



##########
File path: sdks/python/container/boot.go
##########
@@ -185,6 +185,7 @@ func main() {
 	os.Setenv("SEMI_PERSISTENT_DIRECTORY", *semiPersistDir)
 	os.Setenv("LOGGING_API_SERVICE_DESCRIPTOR", proto.MarshalTextString(&pipepb.ApiServiceDescriptor{Url:
*loggingEndpoint}))
 	os.Setenv("CONTROL_API_SERVICE_DESCRIPTOR", proto.MarshalTextString(&pipepb.ApiServiceDescriptor{Url:
*controlEndpoint}))
+	os.Setenv("RUNNER_CAPABILITIES", strings.Join(" ", info.GetRunnerCapabilities()))

Review comment:
       Same here. Parameter order is wrong for strings.Join. list then sep.
   
   Though, until the Go proto update is patched in, it still won't compile.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message