beam-github mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] rohdesamuel commented on a change in pull request #12414: [BEAM-10603] Fix BCJ to stop caching when the cache signature has changed.
Date Wed, 12 Aug 2020 20:35:16 GMT

rohdesamuel commented on a change in pull request #12414:
URL: https://github.com/apache/beam/pull/12414#discussion_r469526548



##########
File path: sdks/python/apache_beam/runners/interactive/background_caching_job.py
##########
@@ -182,7 +182,9 @@ def is_cache_complete(pipeline_id):
   cache_changed = is_source_to_cache_changed(
       user_pipeline, update_cached_source_signature=False)
 
-  return is_done and not cache_changed
+  # Stop reading from the cache is the background job is done or the underlying

Review comment:
       Done. Force pushed this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message