From dev-return-21828-archive-asf-public=cust-asf.ponee.io@beam.apache.org Wed Feb 19 11:08:24 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F9F8180658 for ; Wed, 19 Feb 2020 12:08:23 +0100 (CET) Received: (qmail 85839 invoked by uid 500); 19 Feb 2020 11:08:22 -0000 Mailing-List: contact dev-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list dev@beam.apache.org Received: (qmail 85828 invoked by uid 99); 19 Feb 2020 11:08:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Feb 2020 11:08:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B10AC181310 for ; Wed, 19 Feb 2020 11:08:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.601 X-Spam-Level: X-Spam-Status: No, score=0.601 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URI_HEX=0.1] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id RMMJv08uY8g2 for ; Wed, 19 Feb 2020 11:08:20 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::843; helo=mail-qt1-x843.google.com; envelope-from=david.moravek@gmail.com; receiver= Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 84F327DD70 for ; Wed, 19 Feb 2020 11:08:19 +0000 (UTC) Received: by mail-qt1-x843.google.com with SMTP id j23so3068067qtr.11 for ; Wed, 19 Feb 2020 03:08:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=X0E4c+6/AvLfkmvAuY1+SHUeIkXrKNGlczXa85cn6gQ=; b=EWM2KBosSmmHokwyGYlVHyPsYq1bKkuHk9QLVLpm5p3TItTdsBta7PLqo06foYjxnR r/RfUjFXSTdU1fDGkxyngjR38cIjXgek1gndE6SvWk+VaUFvGE5HGgJ3oj3A2HMwT1tc gE6xecIRJyBSXA+NKUHaSnPg5amrdrkc/yfUSGlCayodY5GLawpCK2dl5wrF7ljbn2WP Cd8DBwMq1B13qljFI9TnYQqm02sOyYwW3WXU6GnJ1MDJX3WazqfiAoyO0/XTK489TFIl 4IV2Qee7zVyOsbgs937VxTpxV9fFMBaYP/Bnm3uRtFi9DIwMqSu/RZ9AobqWpXYL3uXJ +yOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=X0E4c+6/AvLfkmvAuY1+SHUeIkXrKNGlczXa85cn6gQ=; b=sw6BzRdJllP89cU4d7Drks42mbGitJEFjfqocPaSliruoo+I/qWFIYqFmrp008l5cS E3pw4dek282MdKbrTCAV50uOAtY6bff8pzqUEb803hvau+HmxTW2be8CqF+GM8PN5UtR bDBhl7gmwA8HIKHPhVQFF5YEwyvEdi+IOved6Xg5b+/r5AVr5zGAbUANjuJXe/mzGqT6 3+uIjLdlk3kdMFnBpWFGwJHWKXvMY6CNERLGO3TcIQtTnwkz3MDi00ORmNWi+Gk6d48x H2nFyYNl6m/2aiNPC7cZurutTK07FqKZNqRwxXQkCXVYCzIaHtvyBZTbowTIvcu3SQ2S 0VWg== X-Gm-Message-State: APjAAAWLnI1lYqr+wgF4vCIQYbZ50QYKt1nXFXc5y7g1stYAykfgIHVF JNJqXnnk58cJIpX572Cxsrxf1tUHA73bSs6nrgIVmzAx X-Google-Smtp-Source: APXvYqyWmvnrA2nB/nWNxMDkhHDdW1WZVwdjR3/mx3VIxql7LZ3UGZC4z3q/s4IR+deirmKFYRrwb2diK0clVgp+pls= X-Received: by 2002:aed:25a4:: with SMTP id x33mr21756202qtc.165.1582110498078; Wed, 19 Feb 2020 03:08:18 -0800 (PST) MIME-Version: 1.0 References: <5ce5fb83-9467-40f0-936e-9b8c7d7b8b1d@email.android.com> In-Reply-To: <5ce5fb83-9467-40f0-936e-9b8c7d7b8b1d@email.android.com> From: =?UTF-8?Q?David_Mor=C3=A1vek?= Date: Wed, 19 Feb 2020 12:08:06 +0100 Message-ID: Subject: Re: [DISCUSS] Drop support for Flink 1.7 To: dev Content-Type: multipart/alternative; boundary="0000000000003bc30d059eebce83" --0000000000003bc30d059eebce83 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable +1 for dropping 1.7, once we have 1.10 support ready D. On Tue, Feb 18, 2020 at 7:01 PM wrote: > Hi Ismael, > yes, sure. The proposal would be to have snapshot dependency in the > feature branch. The snapshot must be changed to release before merge to > master. > Jan > > Dne 18. 2. 2020 17:55 napsal u=C5=BEivatel Isma=C3=ABl Mej=C3=ADa : > > Just to be sure, you mean Flink 1.11.0-SNAPSHOT ONLY in the next branch > dependency? > We should not have any SNAPSHOT dependency from other projects in Beam. > > On Tue, Feb 18, 2020 at 5:34 PM wrote: > > Hi=3DCr=EF=BF=BDJincheng, > I think there should be a "process" for this. I would propose to: > a) create new branch with support for new (snapshot) flink - currently > that would mean flink 1.11 > b) as part of this brach drop support for all version up to N - 3 > I think th!t that dropping all versions and adding new version should be > atomic, otherwise we risk we release beam version with less than three > supprted flink versions. > I'd suggest to start with the 1.10 branch support, include the drop of 1.= 7 > into that branch. Once 1.10 gets merged, we should create 1.11 with > snapshot dependency to be able to keep up with the release cadence of fli= nk. > WDYT? > Jan > > Dne 18. 2. 2020 15:34 napsal u=C5=BEivatel jincheng sun < > sunjincheng121@gmail.com>: > > Hi folks, > > Apache Flink 1.10 has completed the release announcement [1]n Then we > would like to add Flink 1.10 build target and make Flink Runner compatibl= e > with Flink 1.10 [2]. So, I would suggest that at most three versions of > Flink runner for Apache Beam community according to the update Policy of > Apache Flink releases [3] , i.e. I think it's better to maintain the thre= e > versions of 1.8/1.9/1.10 after add Flink 1.10 build target to Flink runne= r. > > The current existence of Flink runner 1.7 will affect the upgrade of Flin= k > runner 1.8x and 1.9x due to the code of Flink 1.7 is too old, more detail > can be found in [4]. So, we need to drop the support of Flink runner 1.7 > as soon as possible. > > This discussion also CC to @User, due to the change will affect our users= . > And I would appreciate it if you could review the PR [5]. > > Welcome any feedback! > > Best, > Jincheng > > [1] > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/ANNOUNCE-A= pache-Flin+-1-10-0-released-td37564.html > > [2] https://issues.apache.org/jira/browse/BEAM-9295 > [3] https://flink.apache.org/downloads.html#update-policy-for-old-release= s > [4] https://issues.apache.org/jira/browse/BEAM-9299 > [5] https://github.com/apache/beam/pull/10884 > > > > --0000000000003bc30d059eebce83 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
+1 for dropping 1.7, once we have 1.10 support ready<= /div>

D.

<= div dir=3D"ltr" class=3D"gmail_attr">On Tue, Feb 18, 2020 at 7:01 PM <je.ik@seznam.cz> wrote:
Hi I= smael,
yes, sure. The proposal would be to have snap= shot dependency in the feature branch. The snapshot must be changed to rele= ase before merge to master.
Jan

Dne 18. 2. 2020 17:55= napsal u=C5=BEivatel Isma=C3=ABl Mej=C3=ADa <iemejia@gmail.com>:
Just to be sure, you mean Flink 1.11.0-SNAPSHOT= ONLY in the next branch dependency?
We should not have any SNAPSHOT dependency from other p= rojects in Beam.

On Tue, Feb 18, 2= 020 at 5:34 PM <je.= ik@seznam.cz> wrote:
Hi=3DCr=EF=BF=BDJinch= eng,
I think there = should be a "process" for this. I would propose to:
<= div dir=3D"auto">=C2=A0a) create new branch with = support for new (snapshot) flink - currently that would mean flink 1.11
=C2=A0b) as part of th= is brach drop support for all version up to N - 3
I think th!t that dropping all versions and = adding new version should be atomic, otherwise we risk we release beam vers= ion with less than three supprted flink versions.
I'd suggest to start with the 1.10 branc= h support, include the drop of 1.7 into that branch. Once 1.10 gets merged,= we should create 1.11 with snapshot dependency to be able to keep up with = the release cadence of flink.
WDYT?
= =C2=A0Jan

Dne 18. 2. 2020 15:34 napsal= u=C5=BEivatel jincheng sun <sunjincheng121@gmail.com>:
Hi folks,

Apache Flin= k 1.10 has completed the release=C2=A0announcement [1]n Then we would like = to add Flink 1.10 build target and make Flink Runner compatible with Flink = 1.10 [2]. So, I would suggest that at most three versions of Flink runner f= or Apache Beam community according to the update Policy of Apache Flink rel= eases [3] , i.e. I think it's better to maintain the three versions of = 1.8/1.9/1.10 after add Flink 1.10 build target to Flink runner.

The = current existence of Flink runner 1.7 will affect the upgrade of Flink runn= er 1.8x and 1.9x due to the code of Flink 1.7 is too old, more detail can b= e found in [4]. So,=C2=A0 we need to drop the support of Flink runner 1.7 a= s soon as possible.

This discussion also CC to @User, due to the cha= nge will affect our users. And I would appreciate it if you could review th= e PR [5].

Welcome any feedback!

Best,
Jincheng

[1] = http:/= /apache-flink-mailing-list-archive.1008284.n3.nabble.com/ANNOUNCE-Apache-Fl= in+-1-10-0-released-td37564.html
[2] https://issues.apache.org/ji= ra/browse/BEAM-9295
[3] https://flink.apac= he.org/downloads.html#update-policy-for-old-releases
[4] https://= issues.apache.org/jira/browse/BEAM-9299
[5] https://github.com/apache/b= eam/pull/10884


--0000000000003bc30d059eebce83--