From dev-return-10243-archive-asf-public=cust-asf.ponee.io@beam.apache.org Sat Jun 2 10:24:57 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 03365180609 for ; Sat, 2 Jun 2018 10:24:55 +0200 (CEST) Received: (qmail 21111 invoked by uid 500); 2 Jun 2018 08:24:54 -0000 Mailing-List: contact dev-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list dev@beam.apache.org Received: (qmail 21101 invoked by uid 99); 2 Jun 2018 08:24:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Jun 2018 08:24:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D439BC69A6 for ; Sat, 2 Jun 2018 08:24:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -13.611 X-Spam-Level: X-Spam-Status: No, score=-13.611 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=google.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id EeRWizdgxPZU for ; Sat, 2 Jun 2018 08:24:52 +0000 (UTC) Received: from mail-it0-f46.google.com (mail-it0-f46.google.com [209.85.214.46]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 538CB5F358 for ; Sat, 2 Jun 2018 08:24:52 +0000 (UTC) Received: by mail-it0-f46.google.com with SMTP id u4-v6so4478330itg.0 for ; Sat, 02 Jun 2018 01:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=qut81ZIXJVngC5etKrId16BGihGwD0n3JrYVSN/R8jA=; b=UzfG2i80uCdkay83P3VAM/JIoX6BwIPUfTdgkYvikqftDjm7Pj5jtPWk7TFqjkdW6F z/5tv6OrlBQrOM1rSTrS2M6sa1Zf7Bse3HtGNf2vFVQTwn2RMpfSqQ32YZsUe+5NHbTr jNVtPKq+w7FaW3HuKhFJmIgM5dpW4X+ysO2UCHlkvktq3j6Y/nylcRSYsAkf/dS96NCx Ur2oG1ruWz9HxhiPEvhcErG94lDaRKO6TNYfAFUYtQKV4iUtxbqX+5d+w47VZTb7gpdY eBh7R4bhZNwsIrlC4T+irMdrbJx62oI7qdK1l7d6kKlK3PLppcj09WbxN53LVJX5pu0r hDdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=qut81ZIXJVngC5etKrId16BGihGwD0n3JrYVSN/R8jA=; b=GokmM4nJO8QJj2NzWETOITmHfGcEic76TE7UiBiX1TYM3czhuXtBqkgBKeKy5XA2mo KQOv9WR2C1X87K/jC/4m/2gcGaNP4npE/yUk3gmrNrpugUVc9kREzWJAfPsvhM12Dbqe THvh0JhW7B7/t05iSDA93hhXwlRJCXWLaAxUVb+camwBgxMlZBJhEO+PzbyyrZmXpnzS yObm+nsVotQRfliBoJkamzsLGP2ibt3p3tUFWeSVIdd/2hJrxAXI0slELFLiLwsIddv1 C7mCi6G6Nk/q/Vi520JYGxG6AVquM68j9K2aoq9ZIUXUAm9N2UBJQEnd1sk8JI3BJsqO 9tjw== X-Gm-Message-State: APt69E2VBmPJ2EyscfQFepHTUVYgIYTIZIpPssX2I0gEhIZAmPoL3nZG t1qq193gBDk9RLOhGfFeQAZHp1XzZesXvU1kkIB5lD+F X-Google-Smtp-Source: ADUXVKL0PXGEJXWmH/fTaj2IFUAT+6avzXtGdJAOE8R8M/ifgUjzTUmKQWjmHW/2fp8FGgmBX1cWLRsOiNaeLtAJ7aA= X-Received: by 2002:a24:1345:: with SMTP id 66-v6mr6954089itz.129.1527927885217; Sat, 02 Jun 2018 01:24:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Reuven Lax Date: Sat, 2 Jun 2018 11:24:34 +0300 Message-ID: Subject: Re: [VOTE] Code Review Process To: dev@beam.apache.org Content-Type: multipart/alternative; boundary="000000000000d7f78d056da46e67" --000000000000d7f78d056da46e67 Content-Type: text/plain; charset="UTF-8" +1 I believe only some committers were aware of the old policy, and others were effectively doing this anyway. On Sat, Jun 2, 2018 at 2:51 AM Scott Wegner wrote: > +1 > > On Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada wrote: > >> +1 :) glad that we had this discussion >> >> On Fri, Jun 1, 2018, 3:38 PM Udi Meiri wrote: >> >>> +1 >>> >>> On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud >>> wrote: >>> >>>> +1 - I hope this doesn't reduce the urgency to fix the root cause: not >>>> having enough committers. >>>> >>>> On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin >>>>> wrote: >>>>> >>>>>> +1 -- this is encoding what I previously thought the process was and >>>>>> what, in practice, I think was often the behavior of committers anyway. >>>>>> >>>>>> On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou >>>>>> wrote: >>>>>> >>>>>>> +1 >>>>>>> >>>>>>> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw >>>>>>> wrote: >>>>>>> >>>>>>>> +1 >>>>>>>> >>>>>>>> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath < >>>>>>>> chamikara@google.com> wrote: >>>>>>>> >>>>>>>>> +1 >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Cham >>>>>>>>> >>>>>>>>> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster < >>>>>>>>> jasonkuster@google.com> wrote: >>>>>>>>> >>>>>>>>>> +1 >>>>>>>>>> >>>>>>>>>> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> +1 >>>>>>>>>>> >>>>>>>>>>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> +1 >>>>>>>>>>>> >>>>>>>>>>>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev < >>>>>>>>>>>> valentyn@google.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> +1 >>>>>>>>>>>>> >>>>>>>>>>>>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay >>>>>>>>>>>> > wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> +1 >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles < >>>>>>>>>>>>>> klk@google.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> +1 >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh < >>>>>>>>>>>>>>> tgroh@apache.org> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> As we seem to largely have consensus in "Reducing Committer >>>>>>>>>>>>>>>> Load for Code Reviews"[1], this is a vote to change the Beam policy on Code >>>>>>>>>>>>>>>> Reviews to require that >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> (1) At least one committer is involved with the code >>>>>>>>>>>>>>>> review, as either a reviewer or as the author >>>>>>>>>>>>>>>> (2) A contributor has approved the change >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> prior to merging any change. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> This changes our policy from its current requirement that >>>>>>>>>>>>>>>> at least one committer *who is not the author* has approved the change >>>>>>>>>>>>>>>> prior to merging. We believe that changing this process will improve code >>>>>>>>>>>>>>>> review throughput, reduce committer load, and engage more of the community >>>>>>>>>>>>>>>> in the code review process. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Please vote: >>>>>>>>>>>>>>>> [ ] +1: Accept the above proposal to change the Beam code >>>>>>>>>>>>>>>> review/merge policy >>>>>>>>>>>>>>>> [ ] -1: Leave the Code Review policy unchanged >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thomas >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> [1] >>>>>>>>>>>>>>>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> ------- >>>>>>>>>> Jason Kuster >>>>>>>>>> Apache Beam / Google Cloud Dataflow >>>>>>>>>> >>>>>>>>>> See something? Say something. go/jasonkuster-feedback >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>> -- >> Got feedback? go/pabloem-feedback >> >> > --000000000000d7f78d056da46e67 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
+1

I believe only some committers w= ere aware of the old policy, and others were effectively doing this anyway.=

On Sat, Jun 2, = 2018 at 2:51 AM Scott Wegner <sweg= ner@google.com> wrote:
+1

On = Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada <pabloem@google.com> wrote:
+1 :) glad that we had this discussion

On Fri, Jun 1, 2018, 3:38 PM Udi M= eiri <ehudm@google= .com> wrote:
+1

On Fri, Jun 1= , 2018 at 1:46 PM Andrew Pilloud <apilloud@google.com> wrote:
+1 - I hope this doesn't reduce the= urgency to fix the root cause: not having enough committers.

=
On Fri, Jun 1, 2018 at 1:18 PM = Henning Rohde <h= erohde@google.com> wrote:
+1

= On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin <dhalperi@apache.org> wrote:
=
+1 -- this is encoding what= I previously thought the process was and what, in practice, I think was of= ten the behavior of committers anyway.

On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou <yifan= zou@google.com> wrote:
+1

On Fri, Jun 1, 2018 at 12:10 PM Rober= t Bradshaw <rob= ertwb@google.com> wrote:
+1

On Fr= i, Jun 1, 2018 at 12:06 PM Chamikara Jayalath <chamikara@google.com> wrote:
+1

Thanks,
Cham

On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster <jasonkuster@google.com> w= rote:
+1
=
On Fri, Jun 1, 2018 at 11:3= 6 AM Ankur Goenka <goenka@google.com> wrote:
=
+1

On Fri, Jun 1, 2018 at 11:28 AM Charles Chen <ccy@google.com> wrote:
+1

On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieie= v <valentyn@goo= gle.com> wrote:
+1

On F= ri, Jun 1, 2018 at 10:40 AM, Ahmet Altay <altay@google.com> w= rote:
+1

On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles <klk@google= .com> wrote:
+1

On = Fri, Jun 1, 2018 at 10:25 AM Thomas Groh <tgroh@apache.org> wrote:
As we seem to largely have conse= nsus in "Reducing Committer Load for Code Reviews"[1], this is a = vote to change the Beam policy on Code Reviews to require that
(1) At least one committer is involved with the code review, a= s either a reviewer or as the author
(2) A contributor has approv= ed the change

prior to merging any change.

This changes our policy from its current requirement that= at least one committer *who is not the author* has approved the change pri= or to merging. We believe that changing this process will improve code revi= ew throughput, reduce committer load, and engage more of the community in t= he code review process.

Please vote:
[ ]= =C2=A0+1: Accept the above proposal to change the Beam code review/merge po= licy
[ ] -1: Leave the Code Review policy unchanged
Thanks,

Thomas

[1]=C2=A0https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b4= 34f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E




--
<= div dir=3D"ltr">
-------
Jason Kuster
Apache Beam /=C2=A0Google Cloud Dataflow

= See something? Say something. go/jasonkuster-feedback
=

--
Got feedback? go/pabloem-feedback
--000000000000d7f78d056da46e67--