From dev-return-7341-archive-asf-public=cust-asf.ponee.io@beam.apache.org Tue Jan 16 07:35:11 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 4EB2E18065B for ; Tue, 16 Jan 2018 07:35:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3E69C160C46; Tue, 16 Jan 2018 06:35:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3701F160C26 for ; Tue, 16 Jan 2018 07:35:10 +0100 (CET) Received: (qmail 52044 invoked by uid 500); 16 Jan 2018 06:35:09 -0000 Mailing-List: contact dev-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list dev@beam.apache.org Received: (qmail 52034 invoked by uid 99); 16 Jan 2018 06:35:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 06:35:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7173D180336 for ; Tue, 16 Jan 2018 06:35:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.37 X-Spam-Level: ** X-Spam-Status: No, score=2.37 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=google.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VvmJ1GSyIJnw for ; Tue, 16 Jan 2018 06:35:06 +0000 (UTC) Received: from mail-yb0-f170.google.com (mail-yb0-f170.google.com [209.85.213.170]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 777AA5FB71 for ; Tue, 16 Jan 2018 06:35:05 +0000 (UTC) Received: by mail-yb0-f170.google.com with SMTP id h9so6767627ybg.10 for ; Mon, 15 Jan 2018 22:35:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=cwUMKniBElv0YLNmPOoOP2jeYCvsK1OR/qT41ZWjOhI=; b=I4ifH2+mnl0Nk8YZ8SjFErLUseqGN98Q1UhvP8Lg+hQt5lNIr4Ict+WIJyABtMKrqy kxGChuBpnRysLcBZVbq13QT1GZx0SaBs1Gw9W384zGk6IGxe0rKP6N6sMtbN+Wa/NyLg 2+2ieXIGr+ekn8rykRpj7KZmUiw+0tRIlYd0eMu4RDa487ERDFxYWSFfBB4n82hQhk4J JtlC5TlkCron9EjjrtgVDAJpbUlRKsh2ecCnbyTs2aUCwsqj+w6qQW3MdvQVXNaVA7Hs loDQnE8w2N4foyJzDigcBAg97q8xljOKqXXrt0EHqb1Qfr+fYDs3lINUQ8DTIVEGPz6r 6aSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=cwUMKniBElv0YLNmPOoOP2jeYCvsK1OR/qT41ZWjOhI=; b=pi3Fj5vBUEPt4EbAbqTjSVmwcEGGlmDS1soP+3dchF5EmCT/3lCrS6YuhxLj9zPM+O /Ytt6oC+T9j97PALVF6NvbdlcQ+1X5p2qkLxHTj5gyOm4FqYuVEEWOS4+nn+eeTZide1 XlnXrZpwB8T+niyNf2QuOArb6WtLUwXVNZXw//UBTx9tyPWQP2Q4VVPct1Fdo5zPQfz7 Euxbod/rs+/t6ZStLheHdm1P0UDMjIm54IkDVoTyHSJJ0wmwrsyuefKika6InF35r/M3 iM/feFsv3LU2RBQrrrHVKqxr4MtHibjNanRE3ODTs8zwepwZ43oITRoBGUEofb4tC47f TOsg== X-Gm-Message-State: AKGB3mLdaJu1iD5NzJSKrOB9W+1M0qTbR0JRpUX/Gg9Ji/TE6gwu2VmI uiLn/iOimmBlArbTsAFYBNZQaJjuvn+1w2v9XFTNwefm X-Google-Smtp-Source: ACJfBovQliepoDrtnv2q26tHPik2i5BNltuR1kD0zK9Izg7kGs0qSzvURsgTpDOyRRMjEpwtKYwi20AA0tozfwbHGR8= X-Received: by 10.37.181.198 with SMTP id d6mr35913066ybg.498.1516084503935; Mon, 15 Jan 2018 22:35:03 -0800 (PST) MIME-Version: 1.0 References: <2f4eaa41-b676-5acb-8808-d7b119b9d058@nanthrax.net> <46a24c2f-d29e-c977-ddd0-3e3e3ce2e1bf@nanthrax.net> <7dc36231-8c10-1507-8215-a35bcd61b80c@apache.org> In-Reply-To: From: Eugene Kirpichov Date: Tue, 16 Jan 2018 06:34:52 +0000 Message-ID: Subject: Re: Switching to Java 8 To: dev@beam.apache.org Content-Type: multipart/alternative; boundary="089e0821eaa44f08430562deeee7" --089e0821eaa44f08430562deeee7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi JB - any updates here? On Tue, Jan 9, 2018, 2:51 AM Jean-Baptiste Onofr=C3=A9 wr= ote: > Actually, it's part of the build and I will "expand" the java version in > the > enforcer. > > Regards > JB > > On 01/09/2018 11:46 AM, Etienne Chauchot wrote: > > Hi, > > > > +1 as well, excellent news ! > > > > I would add also: remove (AFAIK in some IOs) the enforcer configuration > (like > > [1]) that were put when java 8 was needed in a java 7 build. > > > > [1] > > > > > > [1.8,) > > > > > > > > Etienne > > > > > > Le 08/01/2018 =C3=A0 14:02, Jean-Baptiste Onofr=C3=A9 a =C3=A9crit : > >> I created https://issues.apache.org/jira/browse/BEAM-3426 as umbrella > Jira and > >> created the sub-tasks related to build and examples. > >> > >> Feel free to add the relevant sub-tasks there. > >> > >> Regards > >> JB > >> > >> On 01/08/2018 11:33 AM, Isma=C3=ABl Mej=C3=ADa wrote: > >>> Excellent news ! Probably a good idea to fill JIRAs to all of those. = I > >>> would add: > >>> > >>> - Remove the references in the website to Java 7 > >>> - Remove Java 7 and any related task from the CI > >>> - Update the docker dev build images (I will take this one since > >>> reproducible build is my pet project) > >>> - Upgrade the IOs who were still in older versions because of client > >>> compatibility. I remember SolfIO was one case but probably there are > >>> others. > >>> > >>> > >>> On Mon, Jan 8, 2018 at 7:49 AM, Jean-Baptiste Onofr=C3=A9 > wrote: > >>>> Yes, that's the plan: build first, example "merge" after. > >>>> > >>>> Regards > >>>> JB > >>>> > >>>> On 01/08/2018 07:43 AM, Eugene Kirpichov wrote: > >>>>> > >>>>> Sounds great, thanks! Probably best done as 2 separate steps, becau= se > >>>>> after updating the build scripts, everything else can begin in > parallel? > >>>>> > >>>>> On Sun, Jan 7, 2018 at 10:38 PM Jean-Baptiste Onofr=C3=A9 < > jb@nanthrax.net > >>>>> > wrote: > >>>>> > >>>>> Hi Eugene, > >>>>> > >>>>> I'm taking the build update: Maven/Gradle with enforcer + merg= e > of the > >>>>> examples > >>>>> all together. > >>>>> > >>>>> Regards > >>>>> JB > >>>>> > >>>>> On 01/08/2018 07:34 AM, Eugene Kirpichov wrote: > >>>>> > The vote on user@ about switching to Java 8 has concluded, > >>>>> affirmatively. > >>>>> > > >>>>> > What needs to be done to complete the switch? I can see at > least > >>>>> the > >>>>> following: > >>>>> > - Change maven and gradle scripts to use 1.8 source and > target > >>>>> version > >>>>> > - Fix resulting compilation/test errors (Java8 has slightly > >>>>> different type > >>>>> > checking, more minor issues may arise) > >>>>> > - Remove all special-casing of java8 in build scripts > >>>>> > - Merge all modules like "java8 examples" and "java8 tests" > into > >>>>> respective > >>>>> > non-"java8" modules > >>>>> > - Organize an effort to modernize code to use Java 8 > constructs > >>>>> where > >>>>> > appropriate. Especially important to modernize examples. To > a large > >>>>> extent this > >>>>> > can probably be automated with an IDE. > >>>>> > > >>>>> > Anything else? > >>>>> > > >>>>> > >>>>> -- > >>>>> Jean-Baptiste Onofr=C3=A9 > >>>>> jbonofre@apache.org > >>>>> http://blog.nanthrax.net > >>>>> Talend - http://www.talend.com > >>>>> > >>>> > >>>> -- > >>>> Jean-Baptiste Onofr=C3=A9 > >>>> jbonofre@apache.org > >>>> http://blog.nanthrax.net > >>>> Talend - http://www.talend.com > >> > > > > -- > Jean-Baptiste Onofr=C3=A9 > jbonofre@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com > --089e0821eaa44f08430562deeee7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi JB - any updates here?


On Tue, Jan 9, 2018, 2:51 A= M Jean-Baptiste Onofr=C3=A9 <jb@nanth= rax.net> wrote:
Actually, it= 's part of the build and I will "expand" the java version in = the
enforcer.

Regards
JB

On 01/09/2018 11:46 AM, Etienne Chauchot wrote:
> Hi,
>
> +1 as well, excellent news !
>
> I would add also: remove (AFAIK in some IOs) the enforcer configuratio= n (like
> [1]) that were put when java 8 was needed in a java 7 build.
>
> [1]
>
> <requireJavaVersion>
>=C2=A0 =C2=A0=C2=A0 <version>[1.8,)</version>
> </requireJavaVersion>
>
>
> Etienne
>
>
> Le 08/01/2018 =C3=A0 14:02, Jean-Baptiste Onofr=C3=A9 a =C3=A9crit=C2= =A0:
>> I created https://issues.apache.org/jira/bro= wse/BEAM-3426 as umbrella Jira and
>> created the sub-tasks related to build and examples.
>>
>> Feel free to add the relevant sub-tasks there.
>>
>> Regards
>> JB
>>
>> On 01/08/2018 11:33 AM, Isma=C3=ABl Mej=C3=ADa wrote:
>>> Excellent news ! Probably a good idea to fill JIRAs to all of = those. I
>>> would add:
>>>
>>> - Remove the references in the website to Java 7
>>> - Remove Java 7 and any related task from the CI
>>> - Update the docker dev build images (I will take this one sin= ce
>>> reproducible build is my pet project)
>>> - Upgrade the IOs who were still in older versions because of = client
>>> compatibility. I remember SolfIO was one case but probably the= re are
>>> others.
>>>
>>>
>>> On Mon, Jan 8, 2018 at 7:49 AM, Jean-Baptiste Onofr=C3=A9 <= jb@nanthrax.net>= ; wrote:
>>>> Yes, that's the plan: build first, example "merge= " after.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>> On 01/08/2018 07:43 AM, Eugene Kirpichov wrote:
>>>>>
>>>>> Sounds great, thanks! Probably best done as 2 separate= steps, because
>>>>> after updating the build scripts, everything else can = begin in parallel?
>>>>>
>>>>> On Sun, Jan 7, 2018 at 10:38 PM Jean-Baptiste Onofr=C3= =A9 <jb@nanthrax.ne= t
>>>>> <mailto:jb@nanthrax.net>> wrote:
>>>>>
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 Hi Eugene,
>>>>>
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 I'm taking the build upda= te: Maven/Gradle with enforcer + merge of the
>>>>> examples
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 all together.
>>>>>
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 Regards
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 JB
>>>>>
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 On 01/08/2018 07:34 AM, Eugen= e Kirpichov wrote:
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > The vote on user@ = about switching to Java 8 has concluded,
>>>>> affirmatively.
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > What needs to be d= one to complete the switch? I can see at least
>>>>> the
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 following:
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > - Change maven and= gradle scripts to use 1.8 source and target
>>>>> version
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > - Fix resulting co= mpilation/test errors (Java8 has slightly
>>>>> different type
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > checking, more min= or issues may arise)
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > - Remove all speci= al-casing of java8 in build scripts
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > - Merge all module= s like "java8 examples" and "java8 tests" into
>>>>> respective
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > non-"java8&qu= ot; modules
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > - Organize an effo= rt to modernize code to use Java 8 constructs
>>>>> where
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > appropriate. Espec= ially important to modernize examples. To a large
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 extent this
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > can probably be au= tomated with an IDE.
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > Anything else?
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >
>>>>>
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 --
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 Jean-Baptiste Onofr=C3=A9
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 jbonofre@apache.org <mailto:jbonofre@apache.org> >>>>> =C2=A0=C2=A0=C2=A0=C2=A0 http://blog.nanthrax.net >>>>> =C2=A0=C2=A0=C2=A0=C2=A0 Talend - http://www.talend.com
>>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofr=C3=A9
>>>> j= bonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>
>

--
Jean-Baptiste Onofr=C3=A9
jbonofre@apache.or= g
h= ttp://blog.nanthrax.net
Talend - http://www.talend.com
--089e0821eaa44f08430562deeee7--