beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aromane...@apache.org
Subject [beam] branch master updated: Add a guideline for commits history
Date Tue, 26 Mar 2019 14:08:05 GMT
This is an automated email from the ASF dual-hosted git repository.

aromanenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new c890643  Add a guideline for commits history
     new 1eb2164  Merge pull request #8116: Update a guideline for commits history
c890643 is described below

commit c8906435795f92af6a3450c9b4a1d0780ca2d35b
Author: Etienne Chauchot <echauchot@apache.org>
AuthorDate: Fri Mar 22 14:35:29 2019 +0100

    Add a guideline for commits history
---
 website/src/contribute/committer-guide.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/website/src/contribute/committer-guide.md b/website/src/contribute/committer-guide.md
index 4a2ee71..4a79432 100644
--- a/website/src/contribute/committer-guide.md
+++ b/website/src/contribute/committer-guide.md
@@ -41,6 +41,7 @@ Granularity of changes:
 * It is OK to keep separate commits for different logical pieces of the code, if they make
reviewing and revisiting code easier
 * Making commits isolated is a good practice, authors should be able to relatively easily
split the PR upon reviewer's request
 * Generally, every commit should compile and pass tests.
+* Avoid keeping in history formatting messages such as checkstyle or spotless fixes.  Squash
such commits with previous one.
 
 ## Always get to LGTM ("Looks good to me!")
 


Mime
View raw message