beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lc...@apache.org
Subject [beam] branch master updated: Fixup User_COUNTER_URN_PREFIX to contain the trailing: (#7188)
Date Thu, 06 Dec 2018 17:50:02 GMT
This is an automated email from the ASF dual-hosted git repository.

lcwik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new ecc2d84  Fixup User_COUNTER_URN_PREFIX to contain the trailing: (#7188)
ecc2d84 is described below

commit ecc2d84acc7042c42a8be8adf9982b6a40ee5f64
Author: Alex Amato <ajamato@google.com>
AuthorDate: Thu Dec 6 09:49:55 2018 -0800

    Fixup User_COUNTER_URN_PREFIX to contain the trailing: (#7188)
---
 model/fn-execution/src/main/proto/beam_fn_api.proto | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/model/fn-execution/src/main/proto/beam_fn_api.proto b/model/fn-execution/src/main/proto/beam_fn_api.proto
index 4328fa3..e7586ea 100644
--- a/model/fn-execution/src/main/proto/beam_fn_api.proto
+++ b/model/fn-execution/src/main/proto/beam_fn_api.proto
@@ -253,7 +253,7 @@ message BundleApplication {
   //
   // Each application is able to report information that some runners
   // will use consume when providing a UI or for making scaling and performance
-  // decisions. See https://s.apache.org/beam-bundles-backlog-splitting for 
+  // decisions. See https://s.apache.org/beam-bundles-backlog-splitting for
   // details about what types of signals may be useful to report.
   repeated MonitoringInfo monitoring_infos = 7;
 }
@@ -354,8 +354,9 @@ message MonitoringInfo {
 
 message MonitoringInfoUrns {
   enum Enum {
+    // User counter have this format: 'beam:metric:user:<namespace>:<name>'.
     USER_COUNTER_URN_PREFIX = 0 [(org.apache.beam.model.pipeline.v1.beam_urn) =
-        "beam:metric:user"];
+        "beam:metric:user:"];
 
     ELEMENT_COUNT = 1 [(org.apache.beam.model.pipeline.v1.beam_urn) =
         "beam:metric:element_count:v1"];
@@ -635,7 +636,7 @@ message ProcessBundleSplitRequest {
   // possible, effectively checkpointing when able. The remaining backlog
   // will be relative to the backlog reported during processing.
   //
-  // If the backlog is unspecified for a PTransform, the runner would like 
+  // If the backlog is unspecified for a PTransform, the runner would like
   // the SDK to process all data received for that PTransform.
   map<string, bytes> backlog_remaining = 2;
 }


Mime
View raw message