From commits-return-96556-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Oct 5 07:57:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4686D180649 for ; Fri, 5 Oct 2018 07:57:03 +0200 (CEST) Received: (qmail 1181 invoked by uid 500); 5 Oct 2018 05:57:02 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 1172 invoked by uid 99); 5 Oct 2018 05:57:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Oct 2018 05:57:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D058B1A1CFE for ; Fri, 5 Oct 2018 05:57:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.001 X-Spam-Level: X-Spam-Status: No, score=-109.001 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id hPqFiUZWHFzB for ; Fri, 5 Oct 2018 05:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EC7F95F3E2 for ; Fri, 5 Oct 2018 05:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 76AD7E015E for ; Fri, 5 Oct 2018 05:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2703A24757 for ; Fri, 5 Oct 2018 05:57:00 +0000 (UTC) Date: Fri, 5 Oct 2018 05:57:00 +0000 (UTC) From: "Valentyn Tymofieiev (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-5620) Some tests use assertItemsEqual method, not available in Python 3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639308#comment-16639308 ] Valentyn Tymofieiev commented on BEAM-5620: ------------------------------------------- It's possible although in this case some of our test classes will inherit from unittest.TestCase, while others will inherit from something like apache_beam.testing.util.TestCase, which may cause confusion. Everytime someone reading the code would see the latter, they may be wondering why do we have two classes, and which one needs to be used. While if we have a patch in an individual class, the goal is self-explanatory, but I agree that this is not a perfect solution. Another possibility is to use six.assertCountEqual, but according to the approach we have chosen in Beam [1] , we'd like to use native idioms of Python 3 when possible. This is why we eliminated the usages of six, and removed this dependency. [1] https://docs.google.com/document/d/1xDG0MWVlDKDPu_IW9gtMvxi2S9I0GB0VDTkPhjXT0nE > Some tests use assertItemsEqual method, not available in Python 3 > ----------------------------------------------------------------- > > Key: BEAM-5620 > URL: https://issues.apache.org/jira/browse/BEAM-5620 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Valentyn Tymofieiev > Priority: Major > > See: https://github.com/apache/beam/search?q=assertItemsEqual&unscoped_q=assertItemsEqual -- This message was sent by Atlassian JIRA (v7.6.3#76005)