From commits-return-96510-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Oct 5 02:03:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 87CEA180658 for ; Fri, 5 Oct 2018 02:03:31 +0200 (CEST) Received: (qmail 53953 invoked by uid 500); 5 Oct 2018 00:03:30 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 53944 invoked by uid 99); 5 Oct 2018 00:03:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Oct 2018 00:03:30 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 01FEA85B99; Fri, 5 Oct 2018 00:03:30 +0000 (UTC) Date: Fri, 05 Oct 2018 00:03:29 +0000 To: "commits@beam.apache.org" Subject: [beam] branch master updated: [BEAM-5528] Re-add CREATE_VIEW in portable Flink translators (#6523) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <153869780943.19874.14460184814022819473@gitbox.apache.org> From: thw@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: beam X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 845f8d0abcc5a8d7f93457c27aff0feeb1a867d5 X-Git-Newrev: b57283b6ab6706ecb523bf2e496021dc5b5cfad8 X-Git-Rev: b57283b6ab6706ecb523bf2e496021dc5b5cfad8 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. thw pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new b57283b [BEAM-5528] Re-add CREATE_VIEW in portable Flink translators (#6523) b57283b is described below commit b57283b6ab6706ecb523bf2e496021dc5b5cfad8 Author: Maximilian Michels AuthorDate: Fri Oct 5 02:03:12 2018 +0200 [BEAM-5528] Re-add CREATE_VIEW in portable Flink translators (#6523) --- .../beam/runners/flink/FlinkBatchPortablePipelineTranslator.java | 7 +++++++ .../runners/flink/FlinkStreamingPortablePipelineTranslator.java | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java index bb3a890..e67020d 100644 --- a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java +++ b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java @@ -140,6 +140,13 @@ public class FlinkBatchPortablePipelineTranslator translatorMap.put( PTransformTranslation.RESHUFFLE_URN, FlinkBatchPortablePipelineTranslator::translateReshuffle); + translatorMap.put( + PTransformTranslation.CREATE_VIEW_TRANSFORM_URN, + // https://issues.apache.org/jira/browse/BEAM-5649 + // Need to support this via a NOOP until the primitive is removed + (PTransformNode transform, + RunnerApi.Pipeline pipeline, + BatchTranslationContext context) -> {}); return new FlinkBatchPortablePipelineTranslator(translatorMap.build()); } diff --git a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java index 3f4f7c8..9fe2b2b 100644 --- a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java +++ b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java @@ -169,6 +169,12 @@ public class FlinkStreamingPortablePipelineTranslator translatorMap.put(ExecutableStage.URN, this::translateExecutableStage); translatorMap.put(PTransformTranslation.RESHUFFLE_URN, this::translateReshuffle); + translatorMap.put( + // https://issues.apache.org/jira/browse/BEAM-5649 + // Need to support this via a NOOP until the primitive is removed + PTransformTranslation.CREATE_VIEW_TRANSFORM_URN, + (String id, RunnerApi.Pipeline pipeline, StreamingTranslationContext context) -> {}); + this.urnToTransformTranslator = translatorMap.build(); }