beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5643) Fix broken user_score_it_test
Date Thu, 04 Oct 2018 16:55:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5643?focusedWorklogId=151277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151277
]

ASF GitHub Bot logged work on BEAM-5643:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Oct/18 16:54
            Start Date: 04/Oct/18 16:54
    Worklog Time Spent: 10m 
      Work Description: swegner closed pull request #6567: [BEAM-5643] fix broken python it
test
URL: https://github.com/apache/beam/pull/6567
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/python/apache_beam/examples/complete/game/user_score_it_test.py b/sdks/python/apache_beam/examples/complete/game/user_score_it_test.py
index 1c754a92ff5..a29c99e7b50 100644
--- a/sdks/python/apache_beam/examples/complete/game/user_score_it_test.py
+++ b/sdks/python/apache_beam/examples/complete/game/user_score_it_test.py
@@ -64,8 +64,11 @@ def setUp(self):
   def test_user_score_it(self):
 
     state_verifier = PipelineStateMatcher(PipelineState.DONE)
-    file_verifier = FileChecksumMatcher(self.output + '*-of-*',
-                                        self.DEFAULT_EXPECTED_CHECKSUM)
+    arg_sleep_secs = self.test_pipeline.get_option('sleep_secs')
+    sleep_secs = int(arg_sleep_secs) if arg_sleep_secs is not None else None
+    file_verifier = FileChecksumMatcher(self.output + '/*-of-*',
+                                        self.DEFAULT_EXPECTED_CHECKSUM,
+                                        sleep_secs)
 
     extra_opts = {'input': self.DEFAULT_INPUT_FILE,
                   'output': self.output + '/user-score',


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 151277)
    Time Spent: 2h  (was: 1h 50m)

> Fix broken user_score_it_test
> -----------------------------
>
>                 Key: BEAM-5643
>                 URL: https://issues.apache.org/jira/browse/BEAM-5643
>             Project: Beam
>          Issue Type: Bug
>          Components: test-failures
>            Reporter: yifan zou
>            Assignee: yifan zou
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message