beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5615) Several tests fail on Python 3 with TypeError: 'cmp' is an invalid keyword argument for this function
Date Fri, 05 Oct 2018 14:48:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5615?focusedWorklogId=151618&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151618
]

ASF GitHub Bot logged work on BEAM-5615:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Oct/18 14:47
            Start Date: 05/Oct/18 14:47
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on issue #6570: [BEAM-5615] fix cmp is an invalid
keyword for sort function in python 3
URL: https://github.com/apache/beam/pull/6570#issuecomment-427391412
 
 
   LGTM
   Thank you!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 151618)
    Time Spent: 40m  (was: 0.5h)

> Several tests fail on Python 3 with TypeError: 'cmp' is an invalid keyword argument for
this function
> -----------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-5615
>                 URL: https://issues.apache.org/jira/browse/BEAM-5615
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-harness
>            Reporter: Valentyn Tymofieiev
>            Assignee: Juta Staes
>            Priority: Major
>             Fix For: Not applicable
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> ERROR: test_top (apache_beam.transforms.combiners_test.CombineTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/combiners_test.py",
line 89, in test_top
>     names)  # Note parameter passed to comparator.
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pvalue.py",
line 111, in __or__
>     return self.pipeline.apply(ptransform, self)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pipeline.py",
line 467, in apply
>     label or transform.label)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pipeline.py",
line 477, in apply
>     return self.apply(transform, pvalueish)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pipeline.py",
line 513, in apply
>     pvalueish_result = self.runner.apply(transform, pvalueish)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/runner.py",
line 193, in apply
>     return m(transform, input)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/runner.py",
line 199, in apply_PTransform
>     return transform.expand(input)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/ptransform.py",
line 759, in expand
>     return self._fn(pcoll, *args, **kwargs)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/combiners.py",
line 185, in Of
>     TopCombineFn(n, compare, key, reverse), *args, **kwargs)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pvalue.py",
line 111, in __or__
>     return self.pipeline.apply(ptransform, self)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/pipeline.py",
line 513, in apply
>     pvalueish_result = self.runner.apply(transform, pvalueish)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/runner.py",
line 193, in apply
>     return m(transform, input)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/runner.py",
line 199, in apply_PTransform
>     return transform.expand(input)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/core.py",
line 1251, in expand
>     default_value = combine_fn.apply([], *self.args, **self.kwargs)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/core.py",
line 623, in apply
>     *args, **kwargs)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/combiners.py",
line 362, in extract_output
>     self._sort_buffer(buffer, lt)
>   File "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/combiners.py",
line 295, in _sort_buffer
>     key=self._key_fn)
> TypeError: 'cmp' is an invalid keyword argument for this function



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message