beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4176) Java: Portable batch runner passes all ValidatesRunner tests that non-portable runner passes
Date Tue, 02 Oct 2018 14:02:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=150385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150385
]

ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Oct/18 14:01
            Start Date: 02/Oct/18 14:01
    Worklog Time Spent: 10m 
      Work Description: mxm commented on a change in pull request #6537: [BEAM-4176] Store
and serve termination state after portable job termination
URL: https://github.com/apache/beam/pull/6537#discussion_r221957558
 
 

 ##########
 File path: runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
 ##########
 @@ -103,11 +112,7 @@ public State waitUntilFinish() {
       response = stub.getState(request);
       lastState = getJavaState(response.getState());
     }
-    try {
-      jobService.close();
-    } catch (Exception e) {
-      LOG.warn("Error cleaning up job service", e);
-    }
 
 Review comment:
   Why should we keep the connection to the JobServer if we have reached the final state?
Final implies that no other state can be obtained.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 150385)
    Time Spent: 24h 20m  (was: 24h 10m)

> Java: Portable batch runner passes all ValidatesRunner tests that non-portable runner
passes
> --------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4176
>                 URL: https://issues.apache.org/jira/browse/BEAM-4176
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Ben Sidhom
>            Priority: Major
>         Attachments: Screen Shot 2018-08-14 at 4.18.31 PM.png, Screen Shot 2018-09-03
at 11.07.38 AM.png
>
>          Time Spent: 24h 20m
>  Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message