From commits-return-93823-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Sep 21 17:25:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9047C180656 for ; Fri, 21 Sep 2018 17:25:04 +0200 (CEST) Received: (qmail 80251 invoked by uid 500); 21 Sep 2018 15:25:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 80233 invoked by uid 99); 21 Sep 2018 15:25:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Sep 2018 15:25:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 34C2C1855E6 for ; Fri, 21 Sep 2018 15:25:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id FyCoXHy-gPHu for ; Fri, 21 Sep 2018 15:25:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 174085F41C for ; Fri, 21 Sep 2018 15:25:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 769B3E0D9F for ; Fri, 21 Sep 2018 15:25:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0F4BA23FA0 for ; Fri, 21 Sep 2018 15:25:01 +0000 (UTC) Date: Fri, 21 Sep 2018 15:25:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-5404) Inefficient Serialization of Spanner MutationGroup in pipeline MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5404?focusedWorklogId=3D1= 46412&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-146412 ] ASF GitHub Bot logged work on BEAM-5404: ---------------------------------------- Author: ASF GitHub Bot Created on: 21/Sep/18 15:24 Start Date: 21/Sep/18 15:24 Worklog Time Spent: 10m=20 Work Description: nielm commented on issue #6407: [BEAM-5404] Use Jav= a serialization for MutationGroup objects. URL: https://github.com/apache/beam/pull/6407#issuecomment-423572158 =20 =20 This PR is irrelevant and will be withdrawn: it was a bug in my testin= g which indicated that Java serialization is more efficient =20 My mutations were 10 columns of 10K strings... but the values were _the = same_ 10K string.=20 ie: String stringValue =3D new String( /* 10K char array */) =20 Mutation m =3D Mutation.newInsertOrUpdateBuilder("table1") .set("key").to(UUID.randomUUID().toString()) .set("value0").to(stringValue) .set("value1").to(stringValue) .set("value2").to(stringValue) // etc =20 So when the custom serializer encoded this, it produced a ~100K byte arr= ay,=20 Java serialization was being clever: it only sees one String object to b= e serialized and produced a ~10K byte array... =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 146412) Time Spent: 40m (was: 0.5h) > Inefficient Serialization of Spanner MutationGroup in pipeline > -------------------------------------------------------------- > > Key: BEAM-5404 > URL: https://issues.apache.org/jira/browse/BEAM-5404 > Project: Beam > Issue Type: Bug > Components: io-java-gcp > Affects Versions: 2.3.0, 2.4.0, 2.5.0, 2.6.0 > Reporter: Niel Markwick > Assignee: Chamikara Jayalath > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > The Cloud Spanner connector uses a custom serialization mechanism to conv= ert MutationGroup objects into a byte array.=C2=A0 > This mechanism is very inefficient producing byte arrays approx 10x large= r than simple Java Serialization of the MutationGroup objects, which increa= ses the resources needed by the connector to ~40x the size of the original = mutations. > There are no obvious benefits to using this custom serialization system, = as the objects are deserialized within the pipeline itself.=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)