From commits-return-92409-archive-asf-public=cust-asf.ponee.io@beam.apache.org Thu Sep 13 23:18:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FEA018067A for ; Thu, 13 Sep 2018 23:18:03 +0200 (CEST) Received: (qmail 21207 invoked by uid 500); 13 Sep 2018 21:18:02 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 21198 invoked by uid 99); 13 Sep 2018 21:18:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Sep 2018 21:18:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CB747180675 for ; Thu, 13 Sep 2018 21:18:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id V6mIYZSpvq_t for ; Thu, 13 Sep 2018 21:18:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C83DE5F4E7 for ; Thu, 13 Sep 2018 21:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 47E2BE00A5 for ; Thu, 13 Sep 2018 21:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0A62723F9C for ; Thu, 13 Sep 2018 21:18:00 +0000 (UTC) Date: Thu, 13 Sep 2018 21:18:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-5337) [beam_PostCommit_Java_GradleBuild][:beam-runners-flink_2.11:test][Flake] Build times out in beam-runners-flink target MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5337?focusedWorklogId=3D1= 44082&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-144082 ] ASF GitHub Bot logged work on BEAM-5337: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Sep/18 21:17 Start Date: 13/Sep/18 21:17 Worklog Time Spent: 10m=20 Work Description: angoenka commented on a change in pull request #638= 5: [BEAM-5337] Fix flaky test UnboundedSourceWrapperTest#testValueEmission URL: https://github.com/apache/beam/pull/6385#discussion_r217537490 =20 =20 ########## File path: runners/flink/src/test/java/org/apache/beam/runners/flink/strea= ming/UnboundedSourceWrapperTest.java ########## @@ -187,10 +188,9 @@ public void collect( @Override public void close() {} }); - } catch (SuccessException e) { + } finally { processingTimeUpdateThread.interrupt(); =20 Review comment: In a low probability case when the thread was not sleeping at the time o= f interrupt, the interrupted exception will not be thrown.=20 Instead of interrupting shall we use an atomic boolean etc to terminate = the while loop? Alternatively we can also check on Thread.currentThread().isInterrupted(= ) . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 144082) Time Spent: 1h (was: 50m) > [beam_PostCommit_Java_GradleBuild][:beam-runners-flink_2.11:test][Flake] = Build times out in beam-runners-flink target > -------------------------------------------------------------------------= -------------------------------------------- > > Key: BEAM-5337 > URL: https://issues.apache.org/jira/browse/BEAM-5337 > Project: Beam > Issue Type: Bug > Components: runner-flink, test-failures > Reporter: Mikhail Gryzykhin > Assignee: Maximilian Michels > Priority: Critical > Time Spent: 1h > Remaining Estimate: 0h > > Job times out.=C2=A0 > Failing job url: > [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1414/cons= oleFull] > [https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1406/cons= oleFull] > https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1408/conso= leFull > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)