From commits-return-95154-archive-asf-public=cust-asf.ponee.io@beam.apache.org Sun Sep 30 17:23:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1E05118064A for ; Sun, 30 Sep 2018 17:23:02 +0200 (CEST) Received: (qmail 56358 invoked by uid 500); 30 Sep 2018 15:23:02 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 56349 invoked by uid 99); 30 Sep 2018 15:23:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Sep 2018 15:23:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BD2F6C01C1 for ; Sun, 30 Sep 2018 15:23:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4cyvJ4tR4nxy for ; Sun, 30 Sep 2018 15:23:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DF3E25F396 for ; Sun, 30 Sep 2018 15:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7BB6BE0179 for ; Sun, 30 Sep 2018 15:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0BF5521829 for ; Sun, 30 Sep 2018 15:23:00 +0000 (UTC) Date: Sun, 30 Sep 2018 15:23:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-5036) Optimize FileBasedSink's WriteOperation.moveToOutput() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5036?focusedWorklogId=3D1= 49799&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-149799 ] ASF GitHub Bot logged work on BEAM-5036: ---------------------------------------- Author: ASF GitHub Bot Created on: 30/Sep/18 15:22 Start Date: 30/Sep/18 15:22 Worklog Time Spent: 10m=20 Work Description: timrobertson100 commented on issue #6289: [BEAM-503= 6] Optimize the FileBasedSink WriteOperation.moveToOutput() URL: https://github.com/apache/beam/pull/6289#issuecomment-425728560 =20 =20 Thank you @chamikaramj - can you please look at the responses I provide,= before I address yours?=20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 149799) Time Spent: 7h 10m (was: 7h) > Optimize FileBasedSink's WriteOperation.moveToOutput() > ------------------------------------------------------ > > Key: BEAM-5036 > URL: https://issues.apache.org/jira/browse/BEAM-5036 > Project: Beam > Issue Type: Improvement > Components: io-java-files > Affects Versions: 2.5.0 > Reporter: Jozef Vilcek > Assignee: Tim Robertson > Priority: Major > Time Spent: 7h 10m > Remaining Estimate: 0h > > moveToOutput()=C2=A0methods in=C2=A0FileBasedSink.WriteOperation implemen= ts move by copy+delete. It would be better to use a rename() which can be m= uch more effective for some filesystems. > Filesystem must support cross-directory rename.=C2=A0BEAM-4861=C2=A0is re= lated to this for the case of HDFS filesystem. > Feature was discussed here: > http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4= Mp54pQ+vRrJrBh9Vx0=3DuaKnuPZD_qdh_QDm9VXLLsZw@mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)