beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmet Altay (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (BEAM-5490) Beam should not irreversibly modify inspect.getargspec
Date Wed, 26 Sep 2018 02:07:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ahmet Altay reassigned BEAM-5490:
---------------------------------

    Assignee: Valentyn Tymofieiev

> Beam should not irreversibly modify inspect.getargspec
> ------------------------------------------------------
>
>                 Key: BEAM-5490
>                 URL: https://issues.apache.org/jira/browse/BEAM-5490
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Chuan Yu Foo
>            Assignee: Valentyn Tymofieiev
>            Priority: Major
>
> In the Python SDK, in {{typehints/decorators.py}}, Beam irreversibly monkey-patches {{inspect.getargspec}}
for its own purposes. This is really bad form, since it leads to hard to debug issues in other
modules which also use {{inspect.getargspec}} when Beam is imported. 
> Beam should either maintain its own modified copy of the functions it needs, or else
it should always reverse the monkey-patching so that it does not affect other modules.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message