beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5382) Combiner panics at runtime if MergeAccumulators has a context parameter
Date Wed, 19 Sep 2018 18:33:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5382?focusedWorklogId=145759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145759
]

ASF GitHub Bot logged work on BEAM-5382:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Sep/18 18:32
            Start Date: 19/Sep/18 18:32
    Worklog Time Spent: 10m 
      Work Description: schroederc commented on issue #6434: [BEAM-5382] Add fallback for
non-binary MergeAccumulatorsFn
URL: https://github.com/apache/beam/pull/6434#issuecomment-422911177
 
 
   R: @lostluck

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 145759)
    Time Spent: 20m  (was: 10m)

> Combiner panics at runtime if MergeAccumulators has a context parameter
> -----------------------------------------------------------------------
>
>                 Key: BEAM-5382
>                 URL: https://issues.apache.org/jira/browse/BEAM-5382
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Cody Schroeder
>            Assignee: Cody Schroeder
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> [combine.go#L62|https://github.com/apache/beam/blob/14ef23c/sdks/go/pkg/beam/core/runtime/exec/combine.go#L62]
assumes that a combiner's {{MergeAccumulators}} function must be 2x1 but {{TryCombinePerKey}}
accepts combiner functions with context parameters.  I believe accepting context parameters
is the correct behavior overall.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message