beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5319) Finish Python 3 porting for runners module
Date Wed, 26 Sep 2018 07:52:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5319?focusedWorklogId=148020&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148020
]

ASF GitHub Bot logged work on BEAM-5319:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Sep/18 07:51
            Start Date: 26/Sep/18 07:51
    Worklog Time Spent: 10m 
      Work Description: RobbeSneyders commented on a change in pull request #6451: [BEAM-5319]
Partially port runners
URL: https://github.com/apache/beam/pull/6451#discussion_r220457832
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/cache_manager.py
 ##########
 @@ -30,6 +30,14 @@
 from apache_beam.io import filesystems
 from apache_beam.transforms import combiners
 
+try:                    # Python 3
 
 Review comment:
   I also couldn't just use `urllib.parse.unquote_to_bytes` on both Python 2 and 3, since
it returnes a `future.builtins.newbytes` instance on Python 2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 148020)
    Time Spent: 3h 10m  (was: 3h)

> Finish Python 3 porting for runners module
> ------------------------------------------
>
>                 Key: BEAM-5319
>                 URL: https://issues.apache.org/jira/browse/BEAM-5319
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Robbe
>            Priority: Major
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message