beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-5301) Migrate integration tests for datastore_wordcount
Date Fri, 07 Sep 2018 18:13:00 GMT


ASF GitHub Bot logged work on BEAM-5301:

                Author: ASF GitHub Bot
            Created on: 07/Sep/18 18:12
            Start Date: 07/Sep/18 18:12
    Worklog Time Spent: 10m 
      Work Description: pabloem commented on a change in pull request #6333: [BEAM-5301] migrate
datastore_worcount python integration test to Beam

 File path: sdks/python/apache_beam/examples/cookbook/
 @@ -84,6 +78,18 @@
 from apache_beam.options.pipeline_options import PipelineOptions
 from apache_beam.options.pipeline_options import SetupOptions
+# Protect against environments where datastore library is not available.
+# pylint: disable=wrong-import-order, wrong-import-position
+  from import entity_pb2
+  from import query_pb2
+  from googledatastore import helper as datastore_helper
+  from googledatastore import PropertyFilter
+  from past.builtins import unicode
+except ImportError:
+  pass
 Review comment:
   Thank you!

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 142262)
    Time Spent: 1h 50m  (was: 1h 40m)

> Migrate integration tests for datastore_wordcount
> -------------------------------------------------
>                 Key: BEAM-5301
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: yifan zou
>            Assignee: yifan zou
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h

This message was sent by Atlassian JIRA

View raw message