beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5264) Reference DirectRunner implementation of Python user state and timers API
Date Fri, 07 Sep 2018 15:18:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5264?focusedWorklogId=142218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-142218
]

ASF GitHub Bot logged work on BEAM-5264:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Sep/18 15:17
            Start Date: 07/Sep/18 15:17
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on a change in pull request #6304: [BEAM-5264]
Reference DirectRunner implementation of Python User State and Timers API
URL: https://github.com/apache/beam/pull/6304#discussion_r215980257
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
 ##########
 @@ -565,22 +574,56 @@ def start_bundle(self):
     args = transform.args if hasattr(transform, 'args') else []
     kwargs = transform.kwargs if hasattr(transform, 'kwargs') else {}
 
+    self.user_state_context = None
+    self.user_timer_map = {}
+    if UserStateUtils.is_stateful_dofn(dofn):
 
 Review comment:
   A class with nothing but static methods is a javaism, because everything must be in a class.
For Python it should probably just be in the module. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 142218)
    Time Spent: 5h  (was: 4h 50m)

> Reference DirectRunner implementation of Python user state and timers API
> -------------------------------------------------------------------------
>
>                 Key: BEAM-5264
>                 URL: https://issues.apache.org/jira/browse/BEAM-5264
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>    Affects Versions: 2.6.0
>            Reporter: Charles Chen
>            Assignee: Charles Chen
>            Priority: Major
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> This issue tracks the reference DirectRunner implementation of the Beam Python User
State and Timer API, described here: [https://s.apache.org/beam-python-user-state-and-timers].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message