beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-3194) Support annotating that a DoFn requires stable / deterministic input for replay/retry
Date Fri, 07 Sep 2018 16:23:00 GMT


ASF GitHub Bot logged work on BEAM-3194:

                Author: ASF GitHub Bot
            Created on: 07/Sep/18 16:22
            Start Date: 07/Sep/18 16:22
    Worklog Time Spent: 10m 
      Work Description: robinyqiu commented on a change in pull request #6220: [BEAM-3194]
Add integration test for support of @RequiresStableInput

 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/testing/
 @@ -90,6 +91,27 @@ public FileChecksumMatcher(String checksum, String filePath) {
     this(checksum, filePath, DEFAULT_SHARD_TEMPLATE);
+  /**
+   * Constructor that allows users to specify whether to use shardTemplate or not.
+   *
+   * @param checksum expected checksum string used to verify file content.
+   * @param filePath path of files that's to be verified.
+   * @param useShardTemplate if set to false, will not use shardTemplate to match files
+   */
+  public FileChecksumMatcher(String checksum, String filePath, boolean useShardTemplate)
 Review comment:
   Actually the constructor `FileChecksumMatcher(String checksum, ShardedFile shardedFile)`
you suggested already exists in the class as an internal only constructor.
   Should we deprecate `FileChecksumMatcher(String checksum, ShardedFile shardedFile)`? For
other use cases the files to be matched will still be `NumberedShardedFile`. So I think we
can keep this constructor as it is.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 142235)
    Time Spent: 1h 40m  (was: 1.5h)

> Support annotating that a DoFn requires stable / deterministic input for replay/retry
> -------------------------------------------------------------------------------------
>                 Key: BEAM-3194
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model
>            Reporter: Kenneth Knowles
>            Assignee: Yueyang Qiu
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
> See the thread:
> We need this in order to have truly cross-runner end-to-end exactly once via replay +

This message was sent by Atlassian JIRA

View raw message