From commits-return-88866-archive-asf-public=cust-asf.ponee.io@beam.apache.org Mon Aug 20 14:46:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 037C7180663 for ; Mon, 20 Aug 2018 14:46:02 +0200 (CEST) Received: (qmail 71678 invoked by uid 500); 20 Aug 2018 12:46:02 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 71666 invoked by uid 99); 20 Aug 2018 12:46:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Aug 2018 12:46:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C23E7C1358 for ; Mon, 20 Aug 2018 12:46:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jFEo5RPAX8ob for ; Mon, 20 Aug 2018 12:46:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E31415F2AC for ; Mon, 20 Aug 2018 12:46:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7FE4BE070F for ; Mon, 20 Aug 2018 12:46:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 149172468F for ; Mon, 20 Aug 2018 12:46:00 +0000 (UTC) Date: Mon, 20 Aug 2018 12:46:00 +0000 (UTC) From: "Jozef Vilcek (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-5180) Broken FileResultCoder via parseSchema change MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5180?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16585= 871#comment-16585871 ]=20 Jozef Vilcek commented on BEAM-5180: ------------------------------------ I have added a simple roll-back PR so I can use this in my patched version = and track the bug until best solution is decided > Broken FileResultCoder via parseSchema change > --------------------------------------------- > > Key: BEAM-5180 > URL: https://issues.apache.org/jira/browse/BEAM-5180 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Affects Versions: 2.6.0 > Reporter: Jozef Vilcek > Assignee: Kenneth Knowles > Priority: Blocker > Time Spent: 10m > Remaining Estimate: 0h > > Recently this commit > [https://github.com/apache/beam/commit/3fff58c21f94415f3397e185377e36d3df= 662384] > introduced more strict schema parsing which is breaking the contract betw= een _FileResultCoder_=C2=A0and _FileSystems.matchNewResource()_. > Coder takes _ResourceId_=C2=A0and serialize it via `_toString_` methods a= nd then relies on filesystem being able to parse it back again. Having stri= ct _scheme://_=C2=A0breaks this at least for Hadoop filesystem which use _U= RI_ for _ResourceId_=C2=A0and produce _toString()_=C2=A0in form of `_hdfs:/= some/path_` > I guess the _ResourceIdCoder_=C2=A0is suffering the same problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)