From commits-return-88924-archive-asf-public=cust-asf.ponee.io@beam.apache.org Mon Aug 20 22:12:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F1D29180677 for ; Mon, 20 Aug 2018 22:12:03 +0200 (CEST) Received: (qmail 34515 invoked by uid 500); 20 Aug 2018 20:12:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 34504 invoked by uid 99); 20 Aug 2018 20:12:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Aug 2018 20:12:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 967E9C026F for ; Mon, 20 Aug 2018 20:12:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id oemmChJ5oEKc for ; Mon, 20 Aug 2018 20:12:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7B97C5F41B for ; Mon, 20 Aug 2018 20:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A25B7E04AD for ; Mon, 20 Aug 2018 20:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0EE2D23F98 for ; Mon, 20 Aug 2018 20:12:00 +0000 (UTC) Date: Mon, 20 Aug 2018 20:12:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-5141) Improve error message when SET unregistered options MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5141?focusedWorklogId=136251&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136251 ] ASF GitHub Bot logged work on BEAM-5141: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Aug/18 20:11 Start Date: 20/Aug/18 20:11 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #6216: [BEAM-5141] Improve error message when SET unregistered options URL: https://github.com/apache/beam/pull/6216#issuecomment-414447230 I agree that relying on a *special* exception type is not great. I would suggest that you expose the `PropertyDescriptors` (or something similar) from an instance of `PipelineOptionsFactory`. This way you can programmatically enumerate all options. This would allow you to do things like tab completion and potentially integrate better help information. Note that you'll want to decide whether PropertyDescriptors is the right thing to expose or some other class which contains the property name, property type information, property description, ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 136251) Time Spent: 5h 40m (was: 5.5h) > Improve error message when SET unregistered options > ---------------------------------------------------- > > Key: BEAM-5141 > URL: https://issues.apache.org/jira/browse/BEAM-5141 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Rui Wang > Assignee: Rui Wang > Priority: Major > Fix For: Not applicable > > Time Spent: 5h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)