From commits-return-87120-archive-asf-public=cust-asf.ponee.io@beam.apache.org Tue Aug 7 21:28:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 884BD180676 for ; Tue, 7 Aug 2018 21:28:04 +0200 (CEST) Received: (qmail 78670 invoked by uid 500); 7 Aug 2018 19:28:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 78661 invoked by uid 99); 7 Aug 2018 19:28:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2018 19:28:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 20E7C180711 for ; Tue, 7 Aug 2018 19:28:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WhwdsJIwisQv for ; Tue, 7 Aug 2018 19:28:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BC8CB5F3CD for ; Tue, 7 Aug 2018 19:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0A544E2613 for ; Tue, 7 Aug 2018 19:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4C0B923FA2 for ; Tue, 7 Aug 2018 19:28:00 +0000 (UTC) Date: Tue, 7 Aug 2018 19:28:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-5074) Make BeamSqlRowComparator more general MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5074?focusedWorklogId=3D1= 32033&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-132033 ] ASF GitHub Bot logged work on BEAM-5074: ---------------------------------------- Author: ASF GitHub Bot Created on: 07/Aug/18 19:27 Start Date: 07/Aug/18 19:27 Worklog Time Spent: 10m=20 Work Description: amaliujia commented on issue #6145: [BEAM-5074][SQL= ] improve BeamSqlRowComparator URL: https://github.com/apache/beam/pull/6145#issuecomment-411173546 =20 =20 @apilloud=20 =20 Per discussion, I updated this PR. PTAL. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 132033) Time Spent: 1h (was: 50m) > Make BeamSqlRowComparator more general > -------------------------------------- > > Key: BEAM-5074 > URL: https://issues.apache.org/jira/browse/BEAM-5074 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Rui Wang > Assignee: Rui Wang > Priority: Major > Fix For: Not applicable > > Time Spent: 1h > Remaining Estimate: 0h > > BeamSqlRowComparator returns reversed comparison results (if a < b in ter= ms of value,=C2=A0BeamSqlRowComparator returns a > b).=C2=A0 > =C2=A0 > Make it return forward results and have a reversed comparator to do the c= urrent thing. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)